Change RegisteredTool#inputSchema type from DOMString to object - #241
Open
beaufortfrancois wants to merge 1 commit into
Open
Change RegisteredTool#inputSchema type from DOMString to object#241beaufortfrancois wants to merge 1 commit into
RegisteredTool#inputSchema type from DOMString to object#241beaufortfrancois wants to merge 1 commit into
Conversation
domfarolino
approved these changes
Aug 12, 2026
| otherwise undefined. | ||
| :: the result of [=parse a JSON string to a JavaScript value=] given |tool | ||
| definition|'s [=tool definition/input schema=], if |tool definition|'s [=tool | ||
| definition/input schema=] is not the empty string; otherwise undefined. |
Collaborator
There was a problem hiding this comment.
Let's maybe leave a note under this saying that this will never throw an exception, because the string stored in the tool definition is always a valid JSON string.
| registration. | ||
| :: A JSON Schema object describing the expected input parameters for the tool | ||
| [[!JSON-SCHEMA]]. It is the same value provided at tool registration, via | ||
| {{ModelContextTool/inputSchema}}. |
Collaborator
There was a problem hiding this comment.
It's not literally the same object, so it'll fail object identity == comparisons with the {{ModelContextTool/inputSchema}} object passed in at registration time. So depending on how you read "value", it might be confusing. Should we mention that it's a deep copy of the input schema?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #237 (comment),
ModelContextTool#inputSchemawas defined as anobjectduring registration, butRegisteredTool#inputSchemareturned a stringified JSON schema (DOMString) fromgetTools().This change aligns
RegisteredTool#inputSchemato be anobject(JavaScript object), matchingModelContextTool#inputSchemaand the MCP Tool specification.Hopefully we'll apply the same reasoning to
executeTool(myTool, {})instead ofexecuteTool(myTool, '{}')in #226Preview | Diff