add grok sub byok support for TUI - #14420
Merged
Merged
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR adds Grok subscription OAuth support to the headless TUI, wires Grok into provider parsing and slash-command suggestions, and adds TUI UI/session handling plus tests.
Concerns
- Clearing stored Grok OAuth credentials is gated by the same BYOK/feature policy used for starting a new connection, which can leave existing tokens in secure storage after access is disabled.
Security
- Users must be able to remove stored OAuth tokens even when the feature flag, workspace BYOK access, or member-provided credential policy is disabled.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
moirahuang
approved these changes
Jul 28, 2026
harryalbert
force-pushed
the
harry/APP-4991-grok-sub
branch
from
July 28, 2026 21:55
56f9c7e to
e38eb7a
Compare
harryalbert
enabled auto-merge (squash)
July 28, 2026 22:12
harryalbert
disabled auto-merge
July 28, 2026 22:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Grok subscription BYOK support to the headless TUI.
/add-api-key grokthrough an in-process xAI OAuth flow, opening the browser and accepting either the loopback callback or a manually pasted authorization code./clear-provider-api-key groksupport.Testing
./script/runScreenshots / Videos
https://www.loom.com/share/8108ac54463c437d8ff56a0853b1a0b7
Agent Mode