Prefill Tab Config parameters from external URIs (spec) - #14401
Prefill Tab Config parameters from external URIs (spec)#14401rasitakyol wants to merge 1 commit into
Conversation
Co-Authored-By: Warp <agent@warp.dev>
|
Every PR must be linked to a same-repo issue before Oz can review it. Next step: open or find a same-repo issue describing this change, then link it to this PR by adding See the contribution guidelines for the full readiness model. Powered by Oz |
There was a problem hiding this comment.
Every PR must be linked to a same-repo issue before Oz can review it.
Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-spec when it is ready. Once it is marked, comment /oz-review to re-trigger review.
See the contribution guidelines for the full readiness model.
Powered by Oz
|
/oz-review |
|
I'm re-reviewing this spec-only pull request in response to a review request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
Oz no longer requests changes for this pull request after the latest automated review.
There was a problem hiding this comment.
Overview
This spec PR adds product and technical specs for pre-filling declared Tab Config parameters from external warp://tab_config/... URIs. The specs define the param.<name> namespace, strict all-or-nothing validation, modal confirmation as the trust boundary, ingress/log/telemetry redaction requirements, visible initialization behavior for Text/Repo/Branch parameters, and targeted parser/modal/workspace/security validation.
Concerns
No blocking completeness, clarity, feasibility, issue-alignment, or design-level security concerns found. No approved repository spec context was provided for implementation drift comparison.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Description
Adds product and technical specifications for #12343, following the maintainer's request to design parameter passing and its security boundary before implementation.
The specs define:
param.<name>query format while preservingnew_windowas a separate control;Linked Issue
Closes #12343
ready-to-specorready-to-implement.Testing
This is a documentation-only change, so no runtime tests were added.
./script/format --checkcargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warningscargo clippy -p warp --all-targets --tests -- -D warningscargo clippy -p warp_completer --all-targets --tests -- -D warningsgit diff --cached --checkI have manually tested my changes locally with
./script/run(not applicable to a spec-only change)Agent Mode
CHANGELOG-NONE