Skip to content

Prefill Tab Config parameters from external URIs (spec) - #14401

Open
rasitakyol wants to merge 1 commit into
warpdotdev:masterfrom
rasitakyol:codex/gh12343-tab-config-uri-params-spec
Open

Prefill Tab Config parameters from external URIs (spec)#14401
rasitakyol wants to merge 1 commit into
warpdotdev:masterfrom
rasitakyol:codex/gh12343-tab-config-uri-params-spec

Conversation

@rasitakyol

@rasitakyol rasitakyol commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Description

Adds product and technical specifications for #12343, following the maintainer's request to design parameter passing and its security boundary before implementation.

The specs define:

  • the namespaced param.<name> query format while preserving new_window as a separate control;
  • strict all-or-nothing decoding, size limits, duplicate and unknown-key rejection, and category-only errors;
  • mandatory use of the existing editable confirmation modal for every parameterized Tab Config;
  • ingress-log redaction before host-specific parsing so URI parameter values cannot leak through the current full-URL log;
  • visible Text, Repo, and Branch initialization, including blank/default behavior and multiple-Repo branch-picker semantics;
  • parser, modal, workspace, redaction, and manual security coverage required before implementation.

Linked Issue

Closes #12343

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Screenshots are not applicable because this PR contains specifications only and does not change runtime UI.

Testing

This is a documentation-only change, so no runtime tests were added.

  • ./script/format --check

  • cargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warnings

  • cargo clippy -p warp --all-targets --tests -- -D warnings

  • cargo clippy -p warp_completer --all-targets --tests -- -D warnings

  • git diff --cached --check

  • I have manually tested my changes locally with ./script/run (not applicable to a spec-only change)

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-NONE

Co-Authored-By: Warp <agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Jul 28, 2026
@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label Jul 28, 2026
@rasitakyol
rasitakyol marked this pull request as ready for review July 28, 2026 08:48
@oz-for-oss

oz-for-oss Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@rasitakyol

Every PR must be linked to a same-repo issue before Oz can review it.

Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-spec when it is ready. Once it is marked, comment /oz-review to re-trigger review.

See the contribution guidelines for the full readiness model.

Powered by Oz

oz-for-oss[bot]
oz-for-oss Bot previously requested changes Jul 28, 2026

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rasitakyol

Every PR must be linked to a same-repo issue before Oz can review it.

Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-spec when it is ready. Once it is marked, comment /oz-review to re-trigger review.

See the contribution guidelines for the full readiness model.

Powered by Oz

@rasitakyol

Copy link
Copy Markdown
Contributor Author

/oz-review

@oz-for-oss

oz-for-oss Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@rasitakyol

I'm re-reviewing this spec-only pull request in response to a review request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @moirahuang.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss
oz-for-oss Bot dismissed their stale review July 28, 2026 08:55

Oz no longer requests changes for this pull request after the latest automated review.

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This spec PR adds product and technical specs for pre-filling declared Tab Config parameters from external warp://tab_config/... URIs. The specs define the param.<name> namespace, strict all-or-nothing validation, modal confirmation as the trust boundary, ingress/log/telemetry redaction requirements, visible initialization behavior for Text/Repo/Branch parameters, and targeted parser/modal/workspace/security validation.

Concerns

No blocking completeness, clarity, feasibility, issue-alignment, or design-level security concerns found. No approved repository spec context was provided for implementation drift comparison.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss
oz-for-oss Bot requested a review from moirahuang July 28, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support opening Tab Configs from CLI with parameters

1 participant