Skip to content

Better error message in case of unknown encoding id#8681

Merged
robert3005 merged 1 commit into
developfrom
rk/error
Jul 7, 2026
Merged

Better error message in case of unknown encoding id#8681
robert3005 merged 1 commit into
developfrom
rk/error

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

Unify error messages between layout and array encoding id missing

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/chore A trivial change label Jul 7, 2026
@robert3005 robert3005 requested review from AdamGS and danking July 7, 2026 21:53
@robert3005 robert3005 enabled auto-merge (squash) July 7, 2026 21:53
@codspeed-hq

codspeed-hq Bot commented Jul 7, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚡ 4 improved benchmarks
❌ 1 regressed benchmark
✅ 1602 untouched benchmarks
⏩ 42 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_opt_canonical_into[(100, 100)] 305.2 µs 340.2 µs -10.29%
Simulation chunked_varbinview_canonical_into[(1000, 10)] 190.9 µs 153.9 µs +24%
Simulation chunked_varbinview_into_canonical[(100, 100)] 307.3 µs 272.5 µs +12.79%
Simulation compact_sliced[(4096, 90)] 867.2 ns 779.7 ns +11.22%
Simulation compact_sliced[(16384, 90)] 930.6 ns 843.1 ns +10.38%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/error (c47904a) with develop (1e91494)

Open in CodSpeed

Footnotes

  1. 42 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@robert3005 robert3005 merged commit b9779d6 into develop Jul 7, 2026
77 of 80 checks passed
@robert3005 robert3005 deleted the rk/error branch July 7, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants