Support session-time source configuration in DataFusion, and clear up precedence between config sources#8575
Open
AdamGS wants to merge 4 commits into
Open
Support session-time source configuration in DataFusion, and clear up precedence between config sources#8575AdamGS wants to merge 4 commits into
AdamGS wants to merge 4 commits into
Conversation
Merging this PR will improve performance by 11.9%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | encode_varbin[(1000, 4)] |
157 µs | 139.8 µs | +12.34% |
| ⚡ | Simulation | encode_varbin[(1000, 32)] |
162.5 µs | 144.8 µs | +12.22% |
| ⚡ | Simulation | encode_varbin[(1000, 8)] |
157.3 µs | 140.4 µs | +12.05% |
| ⚡ | Simulation | encode_varbin[(1000, 2)] |
156.1 µs | 140.7 µs | +10.98% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing adamg/support-settings-config-session (2ab0b57) with develop (2a19323)
Footnotes
-
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rational for this change
Makes it possible to configure Vortex FileSource-based tables using
SETstatements on an appropriately configured DataFusion session. This is mostly useful for testing or interactive workflows.What changes are included in this PR?
ExtensionOptionsandConfigExtensionAPIs instead ofconfig_namespaceto get configuration handling for free.What APIs are changed? Are there any user-facing changes?
For users of
VortexSourceandVortexFormat, some APIs might change slightly, and if they expose Vortex through an interactive interface, the config might change slightly.