VortexSession API cleanup pass#8503
Conversation
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | slice_empty_vortex |
310 ns | 368.3 ns | -15.84% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
244.4 ns | 215.3 ns | +13.55% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
304.7 ns | 275.6 ns | +10.58% |
| ⚡ | Simulation | eq_i64_constant |
319 µs | 288.9 µs | +10.43% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing adamg/session-new-api-pass (7d09a33) with develop (1118a20)
Footnotes
-
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
d86eea0 to
8cce41b
Compare
fe9d7d4 to
ff676f7
Compare
5682184 to
ab39ca5
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
ab39ca5 to
c3bd22c
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
7dd3548 to
7d09a33
Compare
Summary
This PR makes the final pass to make the
VortexSessionimmutable, removing theto_builderfunction and trying to clear up all call sites.I've also tried to find all docs referencing it, but the change touches so many places I might've missed something.
One big change here is changing
array_session(which I think I introduced?) todefault_session_builder