test(setup): isolate payload directory parsing - #2509
Open
fengmk2 wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Contributor
Native binary sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
vp (Linux x64) |
Binary | 10.68 MiB | 10.68 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 4.62 MiB | 4.62 MiB | -5 B (-0.00%) |
| NAPI (Linux x64) | Binary | 32.19 MiB | 32.19 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 12.68 MiB | 12.68 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
Binary | 7.98 MiB | 7.98 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 4.03 MiB | 4.03 MiB | -3 B (-0.00%) |
| NAPI (macOS ARM64) | Binary | 39.79 MiB | 39.79 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 16.97 MiB | 16.97 MiB | -1 B (-0.00%) |
vp (Windows x64) |
Binary | 8.57 MiB | 8.57 MiB | 0 B (0.00%) |
vp (Windows x64) |
gzip -9 | 3.74 MiB | 3.74 MiB | -10 B (-0.00%) |
| NAPI (Windows x64) | Binary | 27.02 MiB | 27.02 MiB | 0 B (0.00%) |
| NAPI (Windows x64) | gzip -9 | 10.75 MiB | 10.75 MiB | -1 B (-0.00%) |
| Trampoline (Windows x64) | Binary | 216.50 KiB | 216.50 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 104.34 KiB | 104.34 KiB | 0 B (0.00%) |
| Installer (Windows x64) | Binary | 4.48 MiB | 4.48 MiB | +512 B (+0.01%) |
| Installer (Windows x64) | gzip -9 | 2.10 MiB | 2.10 MiB | +360 B (+0.02%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The payload directory tests created archives and started temporary shell processes. Any setup or process error returned None and caused an unwrap panic.
This change moves output parsing to a pure helper. The tests pass byte input to this helper. They no longer create archives or start processes. The tests now run on all platforms.
This fixes the flaky failure from CI run 32338164079.