fix(env): escape and deduplicate POSIX shell paths - #2494
Open
fengmk2 wants to merge 1 commit into
Open
Conversation
Contributor
Native binary sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
vp (Linux x64) |
Binary | 10.70 MiB | 10.70 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 4.63 MiB | 4.63 MiB | -64 B (-0.00%) |
| NAPI (Linux x64) | Binary | 32.03 MiB | 32.03 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 12.61 MiB | 12.61 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
Binary | 8.00 MiB | 8.00 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 4.04 MiB | 4.04 MiB | -136 B (-0.00%) |
| NAPI (macOS ARM64) | Binary | 39.68 MiB | 39.68 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 16.92 MiB | 16.92 MiB | -2 B (-0.00%) |
vp (Windows x64) |
Binary | 8.59 MiB | 8.59 MiB | 0 B (0.00%) |
vp (Windows x64) |
gzip -9 | 3.75 MiB | 3.75 MiB | +28 B (+0.00%) |
| NAPI (Windows x64) | Binary | 26.91 MiB | 26.91 MiB | 0 B (0.00%) |
| NAPI (Windows x64) | gzip -9 | 10.69 MiB | 10.69 MiB | +32 B (+0.00%) |
| Trampoline (Windows x64) | Binary | 216.50 KiB | 216.50 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 104.34 KiB | 104.34 KiB | +2 B (+0.00%) |
| Installer (Windows x64) | Binary | 4.48 MiB | 4.48 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 2.10 MiB | 2.10 MiB | -2 B (-0.00%) |
fengmk2
force-pushed
the
agent/posix-shell-snapshots
branch
from
August 19, 2026 02:59
31b1349 to
3c608f3
Compare
fengmk2
changed the title
fengmk2
force-pushed
the
agent/posix-shell-snapshots
branch
2 times, most recently
from
August 19, 2026 05:56
6dbc0c3 to
3ac8e95
Compare
fengmk2
marked this pull request as ready for review
August 19, 2026 06:00
fengmk2
requested review from
liangmiQwQ,
naokihaba and
wan9chi
and removed request for
naokihaba
August 19, 2026 06:00
wan9chi
approved these changes
Aug 19, 2026
liangmiQwQ
approved these changes
Aug 19, 2026
fengmk2
force-pushed
the
agent/posix-shell-snapshots
branch
from
August 19, 2026 14:30
3ac8e95 to
7977d2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests selected POSIX shell names but did not source the generated environment file. They did not test the generated shell code.
The old template did not escape special characters in paths. It also removed one duplicate Vite+ bin entry and left other duplicates.
The snapshot runner runs the file in sh, Bash, and Zsh. CI installs Zsh when a Linux runner does not have it. CI checks Zsh on each runner and supplies its path to the snapshot runner.
The renderer escapes values in double-quoted strings. It removes the duplicate bin entries before it adds one entry. The tests cover setup, completion, version selection, unset, and
.node-versionselection.Stack created with GitHub Stacks CLI • Give Feedback 💬