fix(env): escape and test generated Fish paths - #2492
Open
fengmk2 wants to merge 4 commits into
Open
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Contributor
Native binary sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
vp (Linux x64) |
Binary | 10.70 MiB | 10.70 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 4.63 MiB | 4.63 MiB | +107 B (+0.00%) |
| NAPI (Linux x64) | Binary | 32.03 MiB | 32.03 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 12.61 MiB | 12.61 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
Binary | 8.00 MiB | 8.00 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 4.04 MiB | 4.04 MiB | -52 B (-0.00%) |
| NAPI (macOS ARM64) | Binary | 39.68 MiB | 39.68 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 16.92 MiB | 16.92 MiB | 0 B (0.00%) |
vp (Windows x64) |
Binary | 8.59 MiB | 8.59 MiB | 0 B (0.00%) |
vp (Windows x64) |
gzip -9 | 3.75 MiB | 3.75 MiB | +131 B (+0.00%) |
| NAPI (Windows x64) | Binary | 26.91 MiB | 26.91 MiB | 0 B (0.00%) |
| NAPI (Windows x64) | gzip -9 | 10.69 MiB | 10.69 MiB | +27 B (+0.00%) |
| Trampoline (Windows x64) | Binary | 216.50 KiB | 216.50 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 104.34 KiB | 104.34 KiB | -2 B (-0.00%) |
| Installer (Windows x64) | Binary | 4.48 MiB | 4.48 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 2.10 MiB | 2.10 MiB | -1 B (-0.00%) |
This comment was marked as resolved.
This comment was marked as resolved.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
fengmk2
marked this pull request as ready for review
August 19, 2026 02:03
fengmk2
added
test: e2e
fengmk2
marked this pull request as draft
August 19, 2026 02:41
fengmk2
marked this pull request as ready for review
August 19, 2026 03:26
naokihaba
reviewed
Aug 19, 2026
naokihaba
left a comment
naokihaba
left a comment
Collaborator
There was a problem hiding this comment.
I will check the rest as soon as I finish my main work. 🙏
nekomoyi
approved these changes
Aug 19, 2026
nekomoyi
left a comment
nekomoyi
left a comment
Collaborator
There was a problem hiding this comment.
Should we add a test where vp env use fails, verifying that the nonzero status is propagated and VP_NODE_VERSION remains unchanged?
Member
Author
|
@nekomoyi Added in a0972e7. The Fish snapshot now invokes vp env use --invalid-option, asserts that the wrapper returns a nonzero status, and verifies that VP_NODE_VERSION remains 22.18.0. The deterministic failure diagnostic is also recorded in the snapshot. The focused snapshot, Fish unit tests, cargo fmt, and vp check all pass. |
wan9chi
approved these changes
Aug 19, 2026
fengmk2
force-pushed
the
agent/fish-shell-snapshots
branch
from
August 19, 2026 14:30
a0972e7 to
a3bd5de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests did not run
env.fishin Fish. They missed errors in path quoting, PATH updates, and wrapper exit status.Fish returns a nonzero status when
set -etargets a variable that does not exist. The old wrapper stopped before file-based version selection.CI installs Fish and runs the generated file in Fish. The renderer escapes Fish paths and removes duplicate Vite+ bin entries. The wrapper makes unset safe when the version variable does not exist. It returns a failed
vp env usestatus without applying output.The snapshot scheme follows #2191. The snapshots cover setup and version selection. They also cover command failure.