Repository navigation
fsearch: update to 0.3.2 - #62840
Open
gc-user wants to merge 1 commit into
Open
fsearch: update to 0.3.2#62840gc-user wants to merge 1 commit into
gc-user wants to merge 1 commit into
Conversation
Duncaen
requested changes
Oct 5, 2026
| makedepends="gtk+3-devel pcre2-devel" | ||
| build_helper="qemu" | ||
| hostmakedepends="gettext glib-devel pkg-config itstool" | ||
| makedepends="gtk+3-devel pcre2-devel intltool icu-devel" |
Member
There was a problem hiding this comment.
Is intltool actually required in makedepends?
Contributor
Author
There was a problem hiding this comment.
Thanks for the review and your input.
You're correct, is not necessary for successful build.
I guess, I ran into a build error because of the missing itstool package. So, apparently, I went to the source and checked for build dependencies and added intltool and icu-develas they are listed there. As they aren't necessary for a successful build, I removed them again. Also, it should have been libicu77/78-devel, not icu-devel, anyway.
Comment on lines
+21
to
+22
| sed -i '/#include <linux\/fanotify.h>/d' \ | ||
| src/fsearch_folder_monitor_fanotify.c |
Member
There was a problem hiding this comment.
Suggested change
| sed -i '/#include <linux\/fanotify.h>/d' \ | |
| src/fsearch_folder_monitor_fanotify.c | |
| vsed -e '/#include <linux\/fanotify.h>/d' -i src/fsearch_folder_monitor_fanotify.c |
Contributor
Author
There was a problem hiding this comment.
I applied your suggested change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
Notes:
I re-open a new PR after closing a previous one as there's nothing going forward with the PR because of which I closed my previous PR. Maybe one of the two PRs will eventually be merged.
Due to build errors I added the packages
itstool intltool icu-devel.Due to cross-build error I added
build_helper="qemu".Thanks to @ihateemoji for the solution to solve the 64bit-musl cross-build error!