Skip to content

adw-bluetooth: update to 1.2.0. - #61628

Open
xJayMorex wants to merge 1 commit into
void-linux:masterfrom
xJayMorex:adw-bluetooth-1.1.2
Open

xJayMorex wants to merge 1 commit into
void-linux:masterfrom
xJayMorex:adw-bluetooth-1.1.2

Conversation

@xJayMorex

@xJayMorex xJayMorex commented Jul 24, 2026 •

Copy link
Copy Markdown
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64
  • I built this PR locally for these architectures:
    • x86_64-musl

@xJayMorex xJayMorex changed the title adw-bluetooth: update to 1.1.2. [WIP] adw-bluetooth: update to 1.1.2. Jul 24, 2026
@xJayMorex
xJayMorex force-pushed the adw-bluetooth-1.1.2 branch from 81a150a to 1c0fe89 Compare August 2, 2026 17:42
@xJayMorex xJayMorex changed the title [WIP] adw-bluetooth: update to 1.1.2. adw-bluetooth: update to 1.1.2. Aug 2, 2026
@xJayMorex
xJayMorex marked this pull request as ready for review August 2, 2026 17:56
@xJayMorex xJayMorex closed this Sep 30, 2026
@xJayMorex xJayMorex changed the title adw-bluetooth: update to 1.1.2. adw-bluetooth: update to 1.2.0. Sep 30, 2026
@xJayMorex xJayMorex reopened this Sep 30, 2026
@Duncaen

Duncaen commented Oct 4, 2026

Copy link
Copy Markdown
Member

Can you share the cross build issue?

@xJayMorex
xJayMorex force-pushed the adw-bluetooth-1.1.2 branch from 45a972c to b72de98 Compare October 5, 2026 07:17
@xJayMorex

Copy link
Copy Markdown
Contributor Author

Enabled cross build, please have a look at the logs.

@Duncaen Duncaen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this just needs GOARCH, there is currently no go build helper so you'd have to copy this case statement into the template, there are a few packages that do that too:

case "$XBPS_TARGET_MACHINE" in
aarch64*) export GOARCH=arm64;;
armv5*) export GOARCH=arm; export GOARM=5;;
armv6*) export GOARCH=arm; export GOARM=6;;
armv7*) export GOARCH=arm; export GOARM=7;;
i686*) export GOARCH=386;;
x86_64*) export GOARCH=amd64;;
ppc64le*) export GOARCH=ppc64le;;
ppc64*) export GOARCH=ppc64;;
ppc*) export GOARCH=ppc;;
mipsel*) export GOARCH=mipsle;;
mips*) export GOARCH=mips;;
riscv64*) export GOARCH=riscv64;;
esac

The conditional host and make depends you added look wrong. The GI pre_build should probably be restored too.

@xJayMorex

xJayMorex commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor Author

Thanks, I'll take a look. The conditional dependencies are the only way I could make cross compile (almost) work, but I'm pretty sure GOARCH will sort this out as well.

@xJayMorex
xJayMorex force-pushed the adw-bluetooth-1.1.2 branch from b72de98 to 335fdf0 Compare October 5, 2026 15:44
Comment thread srcpkgs/adw-bluetooth/template Outdated
build_style=meson
hostmakedepends="pkg-config nodejs blueprint-compiler glib-devel gjs-devel desktop-file-utils"
makedepends="gjs-devel gtk4 libadwaita"
hostmakedepends="nodejs pkg-config cmake glib-devel gjs-devel blueprint-compiler go gtk4-devel libadwaita-devel"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gjs-devel, gtk4-devel and libadwaita-devel should be only in makedepends.

Why does this need cmake now?

@xJayMorex xJayMorex Oct 5, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross build still fails if gjs-devel, gtk4-devel and libadwaita-devel are not in hostmakedepends.

E.g. ERROR: Program '/usr/bin/gjs-console' not found or not executable etc.

cmake can be removed.

@xJayMorex
xJayMorex force-pushed the adw-bluetooth-1.1.2 branch from 335fdf0 to 11968d3 Compare October 5, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants