Fix Ethernet Samples and docs#334
Merged
Merged
Conversation
Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
KonradBreitsprecherBkd
added
the
needs reviewer
MariusBgm
requested changes
Jun 9, 2026
MariusBgm
left a comment
MariusBgm
left a comment
Collaborator
There was a problem hiding this comment.
the ethernetframe needs to be constructed in a vector, EthernetFrame.frame is only a Span
Co-authored-by: Marius Börschig <marius.boerschig@vector.com> Signed-off-by: KonradBreitsprecherBkd <117755498+KonradBreitsprecherBkd@users.noreply.github.com>
Co-authored-by: Marius Börschig <marius.boerschig@vector.com> Signed-off-by: KonradBreitsprecherBkd <117755498+KonradBreitsprecherBkd@users.noreply.github.com>
Signed-off-by: KonradBreitsprecherBkd <117755498+KonradBreitsprecherBkd@users.noreply.github.com>
Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
KonradBreitsprecherBkd
removed
the
needs reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #333, this PR fixes documentation and sample inconsistencies in Ethernet docs/code samples.
Changes
frameCheckSequencedeclaration indocs/code-samples/eth/ETH_Sender_Receiver.cpp.docs/code-samples/eth/ETH_Erroneous_Transmissions.cpp:ethernetFrame->frameinvalidEthernetFrame->invalidFrameETH_Erroneous_Transmissions.cpptoFrameTransmitHandler.docs/api/services/ethernet.rstto remove outdatedtransmitIdwording forEthernetFrameEventand describe correlation viauserContext.