Repository navigation
Conversation
isFQDN already exposed ignore_max_length for "the standard max length of a domain", but only enforced the per-label 63-char limit. Domains with every label under 63 could still exceed the RFC 1035 / RFC 3696 presentation-form limit of 253 characters and be accepted. Reject strings longer than 253 after trailing-dot / wildcard stripping unless ignore_max_length is set, matching the documented option. Fixes validatorjs#2898
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2899 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2599 2601 +2
Branches 658 659 +1
=========================================
+ Hits 2599 2601 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isFQDNalready documentsignore_max_lengthas skipping "the standard max length of a domain", but the implementation only enforced the per-label 63-character limit. Domains where every label is ≤63 could still exceed the RFC 1035 / RFC 3696 presentation-form limit of 253 characters and be accepted.This rejects strings longer than 253 after trailing-dot / wildcard stripping, unless
ignore_max_lengthis set.Fixes #2898
Changes
src/lib/isFQDN.js: enforcestr.length > 253whenignore_max_lengthis falsetest/validators.test.js+test/validators/isFQDN.test.js: regression coverage for 253/254/260 and the ignore optionTest plan
npm test(build + eslint + mocha) — 325 passingNotes