Repository navigation
sort: let --check take precedence over --merge - #15381
Merged
RenjiSann merged 1 commit intoOct 16, 2026
Merged
Conversation
When both -c/--check and -m/--merge were set, exec() preferred merge and printed the input instead of checking order. GNU still checks. With one disordered file this wrongly exited 0. Fixes uutils#15380
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When both
--check(-c) and--merge(-m) are given with a single input, GNU sort still checks that the input is ordered. uutils preferred the merge path, printed the file, and exited 0 even when the input was disordered.exec()now runs the check path whensettings.checkis set, matching GNU. Multiple-file-crejection is unchanged.Closes #15380
Test plan
cargo test --features "feat_common_core sort" --no-default-features test_check_with_merge_still_checks— passprintf 'b\na\n' | sort -c -m→ exit 1 / disorder; sorted input → exit 0Found with behave.