Skip to content

seq, printf: avoid integer overflow on extreme precision/exponent#13246

Open
sylvestre wants to merge 1 commit into
uutils:mainfrom
sylvestre:precision
Open

seq, printf: avoid integer overflow on extreme precision/exponent#13246
sylvestre wants to merge 1 commit into
uutils:mainfrom
sylvestre:precision

Conversation

@sylvestre

Copy link
Copy Markdown
Contributor

Cap seq's float precision at i32::MAX (as printf already does) and reject values whose decimal exponent does not fit in i32 before the float formatters do exponent math, preventing the panic/wrap reported in #13221.

@codspeed-hq

codspeed-hq Bot commented Jul 1, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 331 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing sylvestre:precision (a9535f7) with main (de2e326)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/misc/io-errors (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!
Congrats! The gnu test tests/tail/pipe-f is now passing!

Cap seq's float precision at i32::MAX (as printf already does) and reject
values whose decimal exponent does not fit in i32 before the float formatters
do exponent math, preventing the panic/wrap reported in uutils#13221.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant