Repository navigation
feat: add a side layout and a group mode to Field, and row links without an overlay - #5204
Merged
traefiker merged 4 commits intoNov 13, 2026
Merged
Conversation
gndz07
reviewed
Nov 13, 2026
A Field with its own label, hint, description or error made its own context and dropped the disabled state of the Field around it, so its control stayed enabled while its siblings were disabled. Move warnOnce to utils, shared by Field and RowLink.
|
🎉 This PR is included in version 13.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fills the layout and a11y gaps in
FieldandRowLinkthat apps still work around today (follow-up to #5199 and #5200).Field (Stitches and Vanilla Extract):
labelPosition="start": the label and the hint go in a column before the control, and the control wraps under it when the space is short.hint: text under the label. The control is described by it.messageSize: the text size of the hint, the description and the error. An inner Field takes the size of the outer one.group: for more than one control. The Field becomesrole="group", named by its label and described by its messages. Each control gets its own error with an inner Field.id. Before, a Field with only text gave its label aforto a missing id.grouplogs a warning.RowLink and Tr:
overlay={false}onRowLink, orlinkOverlay={false}onTr: the link stays in its cell, with no overlay. So the tooltips on the text of the row work.linkOverlaywas missing from auseMemodependency list inAriaTable.http:andhttps:links open in a new tab. Other links, such astel:ormailto:, open as on a plain click, so ajavascript:ordata:URL never goes towindow.open.Small behavior changes, no code change needed:
lineHeight1.4, before 1).foronce its control registers (after hydration with server rendering).grouplogs a warning in development.Dependency changes
None.
Breaking changes
None.
How to test?
sub-44):#sub-44;Good PR checkboxes
Good Review checkboxes
ℹ️ Copy the snippet and paste in the review field to fill it