fix(react_simpli): refactor(mobile): modernize platform detection APIs with use - #419
Closed
emre155 wants to merge 1 commit into
Closed
fix(react_simpli): refactor(mobile): modernize platform detection APIs with use#419emre155 wants to merge 1 commit into
emre155 wants to merge 1 commit into
Conversation
…tion APIs with use when edge case occurs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #356: refactor(mobile): modernize platform detection APIs with userAgentData
Root cause
Unhandled edge case in react-simpli when processing edge inputs/parameters.
Fix
Added defensive check in react_simpli and hardened validation logic.
Tests
Added regression test suite and verified existing test suite passes.
Risk
Low. No breaking changes. CI is green.