Skip to content

fix(cli): align cluster NVIDIA selector handling - #499

Draft
cursor[bot] wants to merge 4 commits into
mainfrom
cursor/cli-sdk-updates-af30
Draft

fix(cli): align cluster NVIDIA selector handling#499
cursor[bot] wants to merge 4 commits into
mainfrom
cursor/cli-sdk-updates-af30

Conversation

@cursor

@cursor cursor Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • allow beta cluster creates to omit NVIDIA selector fields in non-interactive/JSON mode
  • allow --nvidia-version-id to be sent with legacy driver/CUDA selectors
  • update cluster create help examples to prefer canonical NVIDIA version IDs

Tests

  • python3 -m pytest tests/cli/test_beta_clusters.py -k 'NvidiaVersionSelection or TestBetaClustersCreate'
  • python3 -m ruff check src/together/lib/cli/api/beta/clusters/create.py src/together/lib/cli/utils/_help_examples.py tests/cli/test_beta_clusters.py
Open in Web View Automation 

@cursoragent @blainekasten
fix(cli): align cluster NVIDIA selector handling
9d3438a 
Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
@broly-code-security-scanner

broly-code-security-scanner Bot commented Jul 31, 2026

Copy link
Copy Markdown

Broly Security Scan

Note

✅ Clean scan
No vulnerabilities detected in this PR.

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (zai-org/GLM-5.2) · Secrets · SCA · IaC · GH Actions · Base Images · Supply Chain Threats · Exploit Chains · Adversarial Verification

We're continuously improving Broly's accuracy and finding quality — your feedback is valuable. False positives, missed findings, bugs, and feature requests all welcome.

Ask in #security-engineering   Powered by Together AI

blainekasten
blainekasten reviewed Aug 12, 2026
View reviewed changes
Comment thread src/together/lib/cli/api/beta/clusters/create.py
]
NvidiaDriverVersionParameter = Annotated[Optional[str], Parameter(help="Nvidia driver version to use for the cluster")]
CudaVersionParameter = Annotated[Optional[str], Parameter(help="CUDA version to use for the cluster")]
NvidiaDriverVersionParameter = Annotated[

@blainekasten blainekasten Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cursoragent in the cli let's call this --driver

@cursor cursor Bot Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed the cluster create CLI flag from --nvidia-driver-version to --driver.

  • CLI param is now driver → --driver
  • Still maps to API field nvidia_driver_version
  • Updated help/error strings + CLI tests

17 related unit tests passed. Pushed on cursor/cli-sdk-updates-af30 (PR #499).

Open in Web Open in Cursor 

@blainekasten blainekasten Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cursoragent sorry, revert that request. I meant to ask you to change NvidiaVersionIDParameter on L28 to be named --driver

@cursor cursor Bot Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the earlier rename and applied the intended one:

  • --nvidia-driver-version / --cuda-version restored for the legacy pair
  • canonical NVIDIA version ID is now --driver (was --nvidia-version-id)
  • still maps to API nvidia_version_id
  • help examples + tests updated

17 related tests passed. Pushed to PR #499.

Open in Web Open in Cursor 

cursoragent and others added 2 commits August 12, 2026 18:44
@cursoragent @blainekasten
fix(cli): rename cluster create --nvidia-driver-version to --driver
36dab99 
Use the shorter --driver flag for the legacy NVIDIA driver selector in
beta cluster create, and update help/error strings and CLI tests.

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
@cursoragent @blainekasten
fix(cli): expose NVIDIA version ID as --driver
f2d148d 
Revert the earlier rename of the legacy selector. Keep
--nvidia-driver-version/--cuda-version for semantic pairs, and rename
the canonical NVIDIA version catalog flag from --nvidia-version-id to
--driver.

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
@blainekasten

blainekasten commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

@cursoragent resolve conflicts, fix lint and tests

@cursor

cursor Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Done. PR is mergeable again.

  • Merged main; resolved conflicts in _help_examples.py + test_beta_clusters.py
  • Kept --driver for the canonical NVIDIA version ID
  • Kept main’s B300_SXM help test
  • Fixed ruff format on create.py
  • API create tests now include required nvidia_version_id (from main)

Verified locally: full ruff format/check clean, 18 CLI create tests + 20 API create tests (mock) pass.

Open in Web Open in Cursor 

@cursoragent @blainekasten
merge: resolve main conflicts for --driver rename
7880923 
Bring main into the branch, keep canonical NVIDIA version ID as --driver
in help examples, preserve B300 create help coverage, and reformat
create.py for ruff.

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blainekasten blainekasten blainekasten left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blainekasten @cursoragent