Skip to content

test: cover CLI fine-tune model limits - #447

Draft
cursor[bot] wants to merge 3 commits into
mainfrom
cursor/cli-sdk-updates-6ddd
Draft

test: cover CLI fine-tune model limits#447
cursor[bot] wants to merge 3 commits into
mainfrom
cursor/cli-sdk-updates-6ddd

Conversation

@cursor

@cursor cursor Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Update CLI fine-tuning model-limits test fixture to match the generated SDK response shape
  • Add coverage for fine-tuning create --lora using model-limit defaults after the model-limits helper removal

Tests

  • .venv/bin/python -m pytest tests/cli/test_fine_tuning.py tests/unit/test_fine_tuning_resources.py
Open in Web View Automation 

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
@broly-code-security-scanner

broly-code-security-scanner Bot commented Jul 14, 2026

Copy link
Copy Markdown

Broly Security Scan

Note

Clean scan
No vulnerabilities detected in this PR.

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (zai-org/GLM-5.2) · Secrets · SCA · IaC · GH Actions · Base Images · Supply Chain Threats · Exploit Chains · Adversarial Verification

We're continuously improving Broly's accuracy and finding quality — your feedback is valuable. False positives, missed findings, bugs, and feature requests all welcome.

Ask in #security-engineering   Powered by Together AI

@blainekasten

Copy link
Copy Markdown
Collaborator

@cursoragent resolve conflicts

@cursor

cursor Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Resolved and pushed in 95399acf.

  • PR is now mergeable; remaining BLOCKED state is checks/review, not conflicts.
  • Fine-tuning tests: 64 passed.
  • Workspace clean.
Open in Web Open in Cursor 

…s-6ddd

# Conflicts:
#	tests/cli/test_fine_tuning.py

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
@blainekasten

Copy link
Copy Markdown
Collaborator

@cursoragent fix tests here

@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

Fixed and pushed as bae1cc08.

  • Alias test now checks command visibility, not mutable help copy.
  • Focused tests: 65 passed.
  • Full non-integration CI suite: all three matrices passed.
  • Workspace clean.
Open in Web Open in Cursor 

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants