builder: build SSA before compiling packages - #5577
Open
jakebailey wants to merge 1 commit into
Open
Conversation
dgryski
approved these changes
Aug 10, 2026
dgryski
left a comment
dgryski
left a comment
Member
There was a problem hiding this comment.
This fixes the crashes for me. Not sure if anybody else has an idea for a "better" fix though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems as though while
x/ssais safe for concurrent use, if you are building one package while inspecting another in the same program, it may still race.In my testing, just forcing a whole program build is enough to make the race go away. I don't like it, but, I'm fairly certain tinygo uses the entire program anyway.
So, do that, and just document that
CompilePackagerequires its input to already have been built. (There's no way to assert that either...)Fixes #5576