Conversation
This was referenced Sep 5, 2026
Member
|
Please update or replace this PR to follow https://github.com/tinygo-org/net/blob/main/AGENTS.md Thank you. |
TCPListener.SyscallConn mirrors the TCPConn stub, which wazero's socket layer requires. Dialer.Control and ControlContext are fields grpc sets, never invoked here because the netdev dial exposes no raw syscall.RawConn. IPConn.Read delegates to ReadFrom so IPConn satisfies io.Reader for grpc.
0pcom
changed the title
0pcom
force-pushed
the
grpc-wazero-fills
branch
from
September 30, 2026 18:15
84fe369 to
510917c
Compare
Contributor
Author
|
Updated to follow AGENTS.md. The description, commit messages and comments are rewritten, and the fixup commits are gone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #95.
Three source compatibility fills, found while compiling grpc and wazero under
TinyGo.
TCPListener.SyscallConn mirrors the existing TCPConn stub, which wazero's
socket layer requires. Dialer.Control and ControlContext are fields grpc sets,
never invoked because the netdev dial exposes no raw syscall.RawConn.
IPConn.Read delegates to ReadFrom so IPConn satisfies io.Reader, which grpc
type switches on.