Panic when a guaranteed extension lookup misses - #5217
Open
caseydavenport wants to merge 1 commit into
Open
Conversation
Leaves the lookups that can legitimately miss alone, with a comment saying why.
caseydavenport
force-pushed
the
casey-must-find-object
branch
from
August 18, 2026 21:40
68cbb6b to
03151ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the review comment on #5164, converting the extension lookups that cannot miss to the panicking
MustFindObject, so a base render that stops producing an object fails loudly instead of silently skipping the Enterprise layering. Stacked on #5206, which addsMustFindObjectitself, so review that one first.Most of the remaining lookups are staying as
if okbecause the object may not be there - the calico/node daemonset moves to the delete list while the CNI finalizer is being removed, kube-controllers renders nothing while terminating, the tiered-policy passthrough role only exists with an aggregation API server, and the non-cluster-host typha deployment is optional. Those each carry a comment now saying so.Release Note