Move the tiers controller Enterprise namespaces behind an extension - #5199
Open
caseydavenport wants to merge 1 commit into
Open
Move the tiers controller Enterprise namespaces behind an extension#5199caseydavenport wants to merge 1 commit into
caseydavenport wants to merge 1 commit into
Conversation
The tiers controller no longer branches on the variant to decide which namespaces need DNS access, nor watches Tenant itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split out of #5170 to keep that review smaller. The tiers controller had a hardcoded list of Enterprise namespaces that need DNS access, guarded by a variant check, plus a multi-tenant branch that queried tenant namespaces. Both come from the extension now, as one list the core controller appends to, and the Tenant watch goes with them.
Same namespaces on both variants, no rendering change.
Release Note