Move the CSR controller's variant knowledge behind an extension - #5195
Open
caseydavenport wants to merge 4 commits into
Open
Move the CSR controller's variant knowledge behind an extension#5195caseydavenport wants to merge 4 commits into
caseydavenport wants to merge 4 commits into
Conversation
The signable assets, the signing role, the subject lookup for requests no pod issued, and the requestor authorization all come from pkg/extensions.
caseydavenport
force-pushed
the
casey-csr-extension
branch
from
August 14, 2026 21:19
9c932c4 to
e051deb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split out of #5170 to keep that review smaller, and the first of the per-controller ones. The CSR controller had a hardcoded table of Enterprise certificates plus variant checks scattered through the reconcile, so it only signed the right things because it knew what product it was running as. That knowledge moves to an extension:
The core controller keeps the signing, the approval, and the request validation. With no extension registered it signs the same set it always did.
Release Note