Add a test for the kube-controllers IPReservations watch permission - #5147
Merged
caseydavenport merged 1 commit intoAug 10, 2026
Merged
Conversation
caseydavenport
force-pushed
the
casey-kc-ipreservations-watch
branch
from
August 7, 2026 03:45
375af19 to
3e09776
Compare
caseydavenport
changed the title
Brian-McM
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5115 landed the same
watchverb independently, so all that's left here is a test to keep it from regressing. Without the watch, the IPAM syncer retries forever and IPAM stops syncing - which is what a v3-CRD cluster hits once the migration ClusterRole (which grants the wholeprojectcalico.orggroup) is removed.