Skip to content

Links on subpages of mobile burger menu of docs broken #91

Open

Description

@felixbuenemann

If the browser window for the docs gets narrow enough the left hand menu gets moved into a burger menu in the top nav, that can be toggled with a click.

The links in this menu are missing a leading slash, so they are wrong when already on a subpage.

Example Code:

<li class="toctree-l2">
  <a class="reference internal" id="Installing Workflow" href="installing-workflow/">Installing Workflow</a>
</li>

The proper href would be "/installing-workflow/" so that it works on subpages.

Activity

  1. felixbuenemann commented on Mar 14, 2019

    @felixbuenemann
    ContributorAuthor

    Actually the left hand menu uses relative links, so if you are on https://docs.teamhephy.com/installing-workflow/configuring-postgres/ and want to go back to the parent entry it links to "../..".

    In any case this relative path is also not constructed int the burger menu.

  2. kingdonb commented on May 6, 2019

    @kingdonb
    Member

    I have seen this too, and had trouble reproducing it when I went back to try fixing it.

    Thanks for looking into this. I have been using this repo to stage docs with the heroku-buildpack-static nginx buildpack: https://github.com/kingdonb/workflow-docs_build

    The docs build/release process is not continuous or streamlined, but these four commits are my hints and will be rebased against this repo teamhephy/workflow repo the next time I rebuild docs.

    It only takes a couple of minutes to do a release, and is easier than writing new automation for now.

    If you know what needs to change in the jekyll sources, please submit a PR! Otherwise, or if it's not that simple, then I will take a look at what you've found and try to implement it. Sorry for taking so long to get back to you on this report, I had lost track of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions