Point the stale tap/Python-Max references at this repo - #4
Merged
Conversation
Two references still named the repository's former name, tap/Python-Max: - ReadMe.md's build badge, which pointed at a repo that no longer exists, so the badge rendered broken. - package-info.json.in's `website` field, which is user-visible in Max's Package Manager. Both now read tap/PythonTap. Not changed, and worth recording: this is the only host package in the family that does not force C++20 (TapTools-Max, AmbiTap-Max, MuTap-Max and AmbiTap-Pd all do, since Min otherwise pins C++17), so its external and its unit test still build at C++17. The fix is TapTools-Max's BUILDSYSTEM_TARGETS loop, but this repo cannot even be configured without its embedded Python runtime, whose installer is macOS/Windows only -- so applying it here would be an unverifiable change. Logged in taphouse's known-divergences list for a machine that can build it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JhhQ93r2E1QTnCx46YfX8j
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Two one-line fixes:
ReadMe.md's build badge andpackage-info.json.in'swebsitefield both still named the repository's former name,tap/Python-Max.Why
The badge pointed at a repo that no longer exists, so it rendered broken. The
websitefield is user-visible in Max's Package Manager. Both now readtap/PythonTap.Verification
Text only — no build. Worth stating plainly: this repo cannot be built or even configured in a Linux container, because
cmakefails fast on the missing embedded Python runtime, whose installer (scripts/install-runtime.sh/.ps1) is macOS/Windows only. So CI is the first real gate for anything here, and I confirmed only that the two strings are the sole occurrences of the old name across*.md,*.yml,*.txtand*.json*.Notes for the reviewer
Not changed, and recorded rather than silently skipped: this is the only host package in the family that does not force C++20. TapTools-Max, AmbiTap-Max, MuTap-Max and AmbiTap-Pd all do, since Min otherwise pins C++17 — so
tap.python~and its unit test still build at C++17 here. The fix is TapTools-Max'sBUILDSYSTEM_TARGETSloop, which re-forces the standard on every object and test target afteradd_subdirectory.I did not apply it because I cannot configure this repo, let alone compile it, so it would be an unverified CMake change to the one repo where I have no feedback loop at all. It is logged in taphouse's known-divergences list (tap/TapHouse#6) for a machine that can build it — it should be a two-line change plus a test build.
Generated by Claude Code