Skip to content

馃摑 Correct CAP-0075 interface errata - #1996

Merged
jayz22 merged 3 commits into
stellar:masterfrom
JFWooten4:fix/cap-0075-interface-errata
Aug 20, 2026
Merged

馃摑 Correct CAP-0075 interface errata#1996
jayz22 merged 3 commits into
stellar:masterfrom
JFWooten4:fix/cap-0075-interface-errata

Conversation

@JFWooten4

Copy link
Copy Markdown
Contributor

Fixes #1980

cc @jayz22

Align field selectors with the shipped Symbol ABI and correct protocol availability.

Co-authored-by: Codex <noreply@openai.com>
Copilot AI balanced review requested due to automatic review settings August 6, 2026 11:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Corrects CAP-0075鈥檚 normative interface documentation to match the Protocol 25 implementation.

Changes:

  • Changes field selectors from numeric U32Val values to named Symbol values.
  • Corrects availability from Protocol 24 to Protocol 25.

@leighmcculloch
leighmcculloch requested a review from jayz22 August 17, 2026 05:42

@jayz22 jayz22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix! I tagged on another commit with some additional clarifications for better alignment with the code.

@jayz22
jayz22 merged commit d186cf3 into stellar:master Aug 20, 2026
4 checks passed
@JFWooten4
JFWooten4 deleted the fix/cap-0075-interface-errata branch August 20, 2026 16:51
@JFWooten4

JFWooten4 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Next time I think it'd be a lot better if we included the Oxford comma. It isn't entirely clear whether the state sizes are part of the box or their own constituent element. I'm not technically familiar (as I would expect many readers aren't), and so I can't derive that from intuition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix CAP-0075 protocol-version and field-selector contradictions

3 participants