chore: fix JavaScript lint errors (issue #13096)#13097
Conversation
- Remove unused eslint-disable directive in reinterpret-float16/main.js - Add missing Symbol require in has-symbol-support/main.js
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
resolves #13096
Two small lint fixes:
reinterpret-float16/lib/main.js: removed an unused eslint-disable directive
has-symbol-support/lib/main.js: added the missing Symbol require so it passes the require-globals rule
Read, understood, and followed the contributing guidelines