2026.1: Sync latest stackhpc/2025.1 - #2457
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughUpdates repository review automation, host maintenance, deployment workflow, IPA and Kolla versions, Rocky image and repository pins, release notes, and upgrade prerequisite handling. ChangesKayobe maintenance updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CIJob
participant upgrade_prerequisites
participant Kayobe
participant jq
CIJob->>upgrade_prerequisites: execute upgrade prerequisites
upgrade_prerequisites->>Kayobe: retrieve kolla_enable_redis configuration
Kayobe-->>upgrade_prerequisites: return configuration dump
upgrade_prerequisites->>jq: filter localhost Redis setting
jq-->>upgrade_prerequisites: return Redis state
upgrade_prerequisites->>Kayobe: run migrate-valkey when Redis is enabled
Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: aef53f1c-0500-4231-bd67-d2ad5e77fb5b
📒 Files selected for processing (15)
.coderabbit.yaml.github/auto-label.yaml.github/workflows/stackhpc-all-in-one.ymletc/kayobe/ansible/maintenance/reset-bls-entries.ymletc/kayobe/hooks/overcloud-host-package-update/post.d/20-reset-bls-entriesetc/kayobe/hooks/overcloud-host-package-update/post.d/releasenotes/notes/reset-bls-entries-20375af82dfd3517.yamletc/kayobe/ipa.ymletc/kayobe/kolla/globals.ymletc/kayobe/ofed.ymletc/kayobe/pulp-host-image-versions.ymletc/kayobe/pulp-repo-versions.ymletc/kayobe/stackhpc.ymlreleasenotes/notes/r9-r10-kolla-base-distro-75078c4fbae4f785.yamlreleasenotes/notes/rocky-98-python-update-ca5e831d408a67ba.yamltools/upgrade-prerequisites.sh
💤 Files with no reviewable changes (2)
- .github/auto-label.yaml
- .github/workflows/stackhpc-all-in-one.yml
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: Ansible 2.20 lint with Python 3.12
- GitHub Check: Ansible 2.19 lint with Python 3.12
🧰 Additional context used
🪛 Checkov (3.3.8)
etc/kayobe/ansible/maintenance/reset-bls-entries.yml
[low] 13-44: Ensure block is handling task errors properly
(CKV2_ANSIBLE_3)
🔇 Additional comments (13)
.coderabbit.yaml (1)
1-67: LGTM!etc/kayobe/ansible/maintenance/reset-bls-entries.yml (1)
13-15: 🩺 Stability & AvailabilityVerify that fact gathering is guaranteed for this hook.
At Line 14,
ansible_facts.os_familyis evaluated before the block can be skipped, but this play does not explicitly setgather_facts: true. If the hook runner disables fact gathering or supplies incomplete facts, the hook will fail instead of safely doing nothing on non-RedHat hosts. Please confirm that the hook contract always gathers complete facts, or make that dependency explicit.etc/kayobe/hooks/overcloud-host-package-update/post.d/20-reset-bls-entries (1)
1-1: LGTM!etc/kayobe/hooks/overcloud-host-package-update/post.d/releasenotes/notes/reset-bls-entries-20375af82dfd3517.yaml (1)
1-5: LGTM!etc/kayobe/ipa.yml (1)
25-32: LGTM!etc/kayobe/kolla/globals.yml (1)
20-20: LGTM!etc/kayobe/stackhpc.yml (1)
233-233: LGTM!etc/kayobe/ofed.yml (1)
22-22: LGTM!etc/kayobe/pulp-host-image-versions.yml (1)
4-5: LGTM!etc/kayobe/pulp-repo-versions.yml (1)
39-40: LGTM!Also applies to: 161-175
releasenotes/notes/r9-r10-kolla-base-distro-75078c4fbae4f785.yaml (1)
1-5: LGTM!releasenotes/notes/rocky-98-python-update-ca5e831d408a67ba.yaml (1)
1-10: LGTM!tools/upgrade-prerequisites.sh (1)
1-8: LGTM!Also applies to: 12-27, 38-39
286d4b2 to
c4b3556
Compare
The previous Rocky 9.8 host image came with broken python 3.9 which caused issues starting deployments (`ASN1: NOT_ENOUGH_DATA`). An updated python package was released[0] and the host image has been rebuilt with this. OFED kernel module has been built for the latest kernel this image uses (`5.14.0.687.26.1.el9.8`). 0: https://errata.rockylinux.org/RLSA-2026:39798
Added Valkey migration script. This checks how `kolla_enable_redis`` is evaluated. If it's true, the script calls K-A's Valkey migration. Otherwise, it's a NOOP.
Previously there was a hostname-related OVN bug that required a reboot in the AIO CI instances to mitigate. It's been fixed for years[1] so this change reverts the workaround. It'll speed up CI and it's better to know if we regress. [1] https://bugs.launchpad.net/kolla-ansible/+bug/2080552
The GitHub app using it was turned off last summer [1]. [1] https://github.com/apps/product-auto-label
Update kolla_base_distro_version_default_map to select Rocky 9 or Rocky 10 images for each host.
Also ensure that the playbook is safe to run on Ubuntu.
| @@ -0,0 +1 @@ | |||
| ../../../ansible/maintenance/reset-bls-entries.yml No newline at end of file | |||
There was a problem hiding this comment.
I don't think this will work, because kayobe searches for .yml files for hooks https://github.com/stackhpc/kayobe/blob/18ab6f377f282cd6a0f86d4fad6e85227c55d26d/kayobe/cli/commands.py#L224 - but I guess it should be fixed in separate patch
| @@ -0,0 +1,5 @@ | |||
| --- | |||
There was a problem hiding this comment.
this reno is committed under hooks folder
5 participants
No description provided.