Repository navigation
C++ MOODYCAMEL_CONSTEXPR_IF/CATCH blocks are statements; oracle names template dtor calls; re-bless eternity (Part of #5630) - #6764
Merged
Conversation
… not functions; oracle names template destructor calls; re-bless eternity (Part of #5630) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
squid-protocol
added
the
shepherd:merge
Contributor
|
No description provided. |
Contributor
|
No description provided. |
Contributor
squid-protocol
added
shepherd:merge
Contributor
|
No description provided. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5630 (slice 6).
What
cpp.py:MOODYCAMEL_CONSTEXPR_IF (c) {..}andMOODYCAMEL_CATCH(...) {..}open a block likeif/catch; they were read as functions (eternityconcurrentqueue.h: 12 phantom units, the enclosing function lost the block's calls). Same negative-lookahead mechanism as the IFVM / DE_FOR_EACH macros.callgraph_oracle.py: text fallback now names a template destructor callp->~TArray<FString>()as~TArray(template args between the name and(). The engine already did.test_cpp_vm_call_macro_5630.py(3 shapes + calls stay in caller),test_callgraph_oracle.py(template dtor,a = b < c;not misread).eternityonly (functions 7332 -> 7320, callgraph_misses 20 -> 8, recall 0.9987 -> 0.9995; all inconcurrentqueue.h). Call-graph baseline regenerated at 590c805 (23 ports): eternity unparsed 12 -> 3, statement 8 -> 5. Language-crucible goldens (both legs): no drift.Gates
pr_gates --fast9/9,--ratchets9/9, 0 skipped.Class / Sibling gaps
Class: C/C++ macros that open a block like a control keyword (
if,catch,for) and so look like a function header tofunc_start. Handled:DE_FOR_EACH*/DE_FOR_OBSERVERS/DE_NOTIFY*(#6756),IFVM/IFVIRTUAL*(#6760),MOODYCAMEL_CONSTEXPR_IF/MOODYCAMEL_CATCH(here). Sibling gaps:MOODYCAMEL_TRY {(no parens, not matched as a function: no change needed); gzdoommiss:statementresidue (macros TriggerSectorActions, ScreenJobValidate); doomsday ~230 absent class-head edges; libclang C-subset reference (#3784). The block-macro list is per-name: a general rule (all-caps identifier +(...)+{at statement level inside a function body) would cover unseen macros but needs its own proof.Remaining slices
None for this scope.
🤖 Generated with Claude Code