Skip to content

C++ constructor with a brace-init in its initializer list keeps its whole body (Part of #5630) - #6754

Merged
squid-shepherd[bot] merged 6 commits into
mainfrom
churn/5630-20261026T1911Z
Oct 26, 2026
Merged

squid-shepherd[bot] merged 6 commits into
mainfrom
churn/5630-20261026T1911Z

Conversation

@squid-protocol

@squid-protocol squid-protocol commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

Part of #5630.

What

A C++ constructor whose member-initializer list holds a brace-init (hiddenTags({"a", "b"}), ids{1, 2}, a lambda argument with nested braces) lost its body: the func_start rule's initializer run (:[^{;]{0,2000}) stopped at the brace-init's {, and Mode B (_slice_by_braces) takes the first { from the match start as the body brace, so the unit ended three lines in and every call in the real body was credited to nobody. doomsday Impl (packageswidget.cpp:504) lost 60 edges.

Fix: cpp.py func_start consumes balanced initializer entries (paren groups holding up to three brace levels, and identifier-attached flat brace-inits), falling back to the old plain run when an entry does not balance; detector.py Mode B takes match.end() - 1 as the body brace for cpp when the match ends in { and an earlier { sits inside it (this also covers a = {} default argument).

Evidence (DOOM callgraph oracle, 23 ports rescanned at 718e6d5, before merging #6753)

port recall before -> after precision
doomsday 0.9887 -> 0.9906 (agree 68793 -> 68926) 0.9652 -> 0.9655
eternity 0.9986 -> 0.9987 0.9869
odamex 0.9981 -> 0.9989 0.9800
gzdoom 0.9972 (same) 0.9659 -> 0.9658 (+4 engine-only absent edges, newly bodied units)
Others unchanged. --fail-on-regression against the old baseline passes; baseline regenerated. Doomsday misses by shape: statement 155 -> 103, other 98 -> 74, after-operator 58 -> 39, nested-argument 67 -> 48.

Golden re-bless (both legs): drift is cpp/powertoys/FancyZones.cpp (the lambda-in-initializer shape) plus the spatial-coordinate shifts that follow from its changed mass; no other language's extraction moved.

Merged-engine baseline (10e59df, includes #6753): doomsday recall 0.9918, precision 0.9656 (agree 69036); --fail-on-regression against main's baseline passes before the regeneration. The per-port table above was measured before the merge.

Class / Sibling gaps

Class: a C++ function whose unit ends before its real body because a { precedes the body brace inside the matched head. Members handled here: constructor init-list brace-init x({..}) and x{..}, lambda argument in an init-list entry (nested braces to depth 3), = {} default argument. Tests: test_cpp_ctor_init_brace_5630.py (5 init shapes, plain list, default arg).
Sibling gaps (none from the burned COBOL estates; DOOM oracle only):

  • unparsed 243 misses in doomsday: macro class headers (DE_GUI_PIMPL(X), DE_PIMPL, DE_OBSERVES) whose bodies are methods under a macro "function"; different mechanism (macro-class extent), next slice.
  • Lambda init entries nested deeper than three brace levels, or with unbalanced parens, still fall back to the old plain run.
  • gzdoom statement 84 and doomsday ctor-init 92 misses: not examined here.

Remaining slices

Macro-class header extent (cpp.py + detector.py + test + baseline); #3784 libclang reference is still open (acceptance item not met here).

Gates

pr_gates --fast 9/9, --ratchets 9/9 pass (0 skipped), pre-PR guards + time ratchet pass; C/C++ extraction tests pass. Cross-repo: none.

Lessons for agents

  • doom_speedrun.py scan keys scans by HEAD sha: commit the engine change before scanning, and a symlink to an older sha's scan is valid only while gitgalaxy/ is unchanged.
  • Mode B's cpp body brace is the first { from the match start, not the match's own last {: any func_start head that can contain { needs the detector side fixed too, not just the regex.

🤖 Generated with Claude Code

squid-protocol and others added 6 commits October 26, 2026 15:16
…hole body (Part of #5630)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… its body (powertoys FancyZones.cpp) (Part of #5630)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…day recall .9887 -> .9906) (Part of #5630)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…init + #6753) (Part of #5630)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@squid-protocol squid-protocol added the shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md label Oct 26, 2026
@squid-shepherd

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd
squid-shepherd Bot marked this pull request as ready for review October 26, 2026 21:38
@github-actions

Copy link
Copy Markdown
Contributor

🐦‍⬛ Muninn Security Scan

✅ No security issues found.

🐦‍⬛ Powered by Muninn · Skald Lab

@squid-shepherd
squid-shepherd Bot enabled auto-merge (squash) October 26, 2026 21:42
@squid-protocol squid-protocol added shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md and removed shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md labels Oct 26, 2026
@squid-shepherd

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd

Copy link
Copy Markdown
Contributor

PR #6754 @ e8bd45f: 3 failed check(s)

== shard 1 (1669449 LOC) (failure) -- real
https://github.com/squid-protocol/gitgalaxy/actions/runs/40406097105/job/121864223899
repro: python tests/tools/pr_gates.py --fast
failing tests: tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[doomsday] tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[edge-classic]
errors:
E AssertionError:
tests/doom_rosetta/test_doom_rosetta.py:47: AssertionError
FAILED tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[doomsday] - AssertionError:
FAILED tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[edge-classic] - AssertionError:
##[error]Process completed with exit code 1.
log tail:
FAILED tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[edge-classic] - AssertionError:
edge-classic: 2 difference(s) from the golden
file source_files/edge/r_image.cc: func_hash 'e559ee70ca2d0fe9' -> '75691cfb4bacc524'
file source_files/epi/epi_str_hash.h: func_hash 'e56a9d84bc3bca9d' -> '8eaa046569161062'
(bless an intended change with tests/tools/doom_rosetta_check.py --update --yes)
assert not "edge-classic: 2 difference(s) from the golden\n file source_files/edge/r_image.cc: func_hash 'e559ee70ca2d0fe9' -> '75691cfb4bacc524'\n file source_files/epi/epi_str_hash.h: func_hash 'e56a9d84bc3bca9d' -> '8eaa046569161062'"
2 failed, 8 passed, 26 deselected in 202.75s (0:03:22)
##[error]Process completed with exit code 1.
##[group]Run s=$(( $(date +%s) - T0 ))
s=$(( $(date +%s) - T0 ))
echo "shard 1 (1669449 LOC): ${s}s" >> "$GITHUB_STEP_SUMMARY"
shell: /usr/bin/bash -e {0}
env:
GITGALAXY_LICENSE_KEY: COMMUNITY_FREE_TIER
DOOM_SPEEDRUN_WORK: /home/runner/work/gitgalaxy/gitgalaxy/../doom-work
DOOM_ROSETTA_PORTS: chocolate-doom,cssdoom,dartdoom,doomgeneric,doomsday,edge-classic,mood,room4doom,rust-doom,sdl-doom
T0: 1793050755
pythonLocation: /opt/hostedtoolcache/Python/3.12.15/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib
##[endgroup]
Post job cleanup.
[command]/usr/bin/git version
git version 2.55.0
Temporarily overriding HOME='/home/runner/work/_temp/fc79611f-9307-43bd-9b0e-2d2ab2621951' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/gitgalaxy/gitgalaxy/gitgalaxy
Removing SSH command configuration
[command]/usr/bin/git config --local --name-only --get-regexp core.sshCommand
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/usr/bin/git config --local --name-only --get-regexp http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http.https://github.com/.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/usr/bin/git config --local --name-only --get-regexp ^includeIf.gitdir:
[command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Cleaning up orphan processes

== shard 2 (1666363 LOC) (failure) -- real
https://github.com/squid-protocol/gitgalaxy/actions/runs/40406097105/job/121864223669
repro: python tests/tools/pr_gates.py --fast
failing tests: tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[gzdoom] tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[odamex]
errors:
E AssertionError:
tests/doom_rosetta/test_doom_rosetta.py:47: AssertionError
FAILED tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[odamex] - AssertionError:
FAILED tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[gzdoom] - AssertionError:
##[error]Process completed with exit code 1.
log tail:
summary.functions: 20698 -> 20699
summary.gg_functions: 18489 -> 18490
file src/common/scripting/dap/BreakpointManager.cpp: func_hash '58f9ac83a54243aa' -> 'ba18f6e9aeeeea06'
file src/common/textures/formats/pngtexture.cpp: functions 11 -> 12, func_hash 'b673dee923d32828' -> 'bbe805881e56cbbe'
(bless an intended change with tests/tools/doom_rosetta_check.py --update --yes)
assert not "gzdoom: 7 difference(s) from the golden\n summary.callgraph_engine_only: 17 -> 21\n summary.callgraph_misses: 120 -...ile src/common/textures/formats/pngtexture.cpp: functions 11 -> 12, func_hash 'b673dee923d32828' -> 'bbe8058
2 failed, 9 passed, 26 deselected in 201.19s (0:03:21)
##[error]Process completed with exit code 1.
##[group]Run s=$(( $(date +%s) - T0 ))
s=$(( $(date +%s) - T0 ))
echo "shard 2 (1666363 LOC): ${s}s" >> "$GITHUB_STEP_SUMMARY"
shell: /usr/bin/bash -e {0}
env:
GITGALAXY_LICENSE_KEY: COMMUNITY_FREE_TIER
DOOM_SPEEDRUN_WORK: /home/runner/work/gitgalaxy/gitgalaxy/../doom-work
DOOM_ROSETTA_PORTS: agentic-cobol-doom-codex,doom-ascii,doom-fx,doom-scheme,doom3do,doomretro,fps-cob,gzdoom,mochadoom,nugget-doom,odamex
T0: 1793050748
pythonLocation: /opt/hostedtoolcache/Python/3.12.15/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib
##[endgroup]
Post job cleanup.
[command]/usr/bin/git version
git version 2.55.0
Temporarily overriding HOME='/home/runner/work/_temp/84e733f0-ecde-4ebd-b7f0-8c2803b125de' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/gitgalaxy/gitgalaxy/gitgalaxy
Removing SSH command configuration
[command]/usr/bin/git config --local --name-only --get-regexp core.sshCommand
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/usr/bin/git config --local --name-only --get-regexp http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http.https://github.com/.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/usr/bin/git config --local --name-only --get-regexp ^includeIf.gitdir:
[command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Cleaning up orphan processes

== shard 3 (1667394 LOC) (failure) -- real
https://github.com/squid-protocol/gitgalaxy/actions/runs/40406097105/job/121864223698
repro: python tests/tools/pr_gates.py --fast
failing tests: tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[eternity]
errors:
E AssertionError:
tests/doom_rosetta/test_doom_rosetta.py:47: AssertionError
FAILED tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[eternity] - AssertionError:
##[error]Process completed with exit code 1.
log tail:
eternity: 3 difference(s) from the golden
summary.callgraph_misses: 22 -> 20
summary.callgraph_recall: 0.9986 -> 0.9987
file source/acs_intr.h: func_hash '501716b534089ac0' -> 'e633745d63c78bec'
(bless an intended change with tests/tools/doom_rosetta_check.py --update --yes)
assert not "eternity: 3 difference(s) from the golden\n summary.callgraph_misses: 22 -> 20\n summary.callgraph_recall: 0.9986 -> 0.9987\n file source/acs_intr.h: func_hash '501716b534089ac0' -> 'e633745d63c78bec'"
1 failed, 10 passed, 26 deselected in 204.00s (0:03:23)
##[error]Process completed with exit code 1.
##[group]Run s=$(( $(date +%s) - T0 ))
s=$(( $(date +%s) - T0 ))
echo "shard 3 (1667394 LOC): ${s}s" >> "$GITHUB_STEP_SUMMARY"
shell: /usr/bin/bash -e {0}
env:
GITGALAXY_LICENSE_KEY: COMMUNITY_FREE_TIER
DOOM_SPEEDRUN_WORK: /home/runner/work/gitgalaxy/gitgalaxy/../doom-work
DOOM_ROSETTA_PORTS: doom-ios,doom-wasm,doom3-bfg,dsda-doom,eternity,freedoom,fsharp-doom,gore,linuxdoom,puredoom,woof
T0: 1793050751
pythonLocation: /opt/hostedtoolcache/Python/3.12.15/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib
##[endgroup]
Post job cleanup.
[command]/usr/bin/git version
git version 2.55.0
Temporarily overriding HOME='/home/runner/work/_temp/a0ae87f4-1786-4e5d-8572-bd986bdbf841' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/gitgalaxy/gitgalaxy/gitgalaxy
Removing SSH command configuration
[command]/usr/bin/git config --local --name-only --get-regexp core.sshCommand
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/usr/bin/git config --local --name-only --get-regexp http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http.https://github.com/.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/usr/bin/git config --local --name-only --get-regexp ^includeIf.gitdir:
[command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Cleaning up orphan processes

@squid-shepherd squid-shepherd Bot added the shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md label Oct 26, 2026
@squid-shepherd

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd

Copy link
Copy Markdown
Contributor

PR #6754 @ e8bd45f: 3 failed check(s)

== shard 1 (1669449 LOC) (failure) -- real
https://github.com/squid-protocol/gitgalaxy/actions/runs/40406097105/job/121864223899
repro: python tests/tools/pr_gates.py --fast
failing tests: tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[doomsday] tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[edge-classic]
errors:
E AssertionError:
tests/doom_rosetta/test_doom_rosetta.py:47: AssertionError
FAILED tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[doomsday] - AssertionError:
FAILED tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[edge-classic] - AssertionError:
##[error]Process completed with exit code 1.
log tail:
FAILED tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[edge-classic] - AssertionError:
edge-classic: 2 difference(s) from the golden
file source_files/edge/r_image.cc: func_hash 'e559ee70ca2d0fe9' -> '75691cfb4bacc524'
file source_files/epi/epi_str_hash.h: func_hash 'e56a9d84bc3bca9d' -> '8eaa046569161062'
(bless an intended change with tests/tools/doom_rosetta_check.py --update --yes)
assert not "edge-classic: 2 difference(s) from the golden\n file source_files/edge/r_image.cc: func_hash 'e559ee70ca2d0fe9' -> '75691cfb4bacc524'\n file source_files/epi/epi_str_hash.h: func_hash 'e56a9d84bc3bca9d' -> '8eaa046569161062'"
2 failed, 8 passed, 26 deselected in 202.75s (0:03:22)
##[error]Process completed with exit code 1.
##[group]Run s=$(( $(date +%s) - T0 ))
s=$(( $(date +%s) - T0 ))
echo "shard 1 (1669449 LOC): ${s}s" >> "$GITHUB_STEP_SUMMARY"
shell: /usr/bin/bash -e {0}
env:
GITGALAXY_LICENSE_KEY: COMMUNITY_FREE_TIER
DOOM_SPEEDRUN_WORK: /home/runner/work/gitgalaxy/gitgalaxy/../doom-work
DOOM_ROSETTA_PORTS: chocolate-doom,cssdoom,dartdoom,doomgeneric,doomsday,edge-classic,mood,room4doom,rust-doom,sdl-doom
T0: 1793050755
pythonLocation: /opt/hostedtoolcache/Python/3.12.15/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib
##[endgroup]
Post job cleanup.
[command]/usr/bin/git version
git version 2.55.0
Temporarily overriding HOME='/home/runner/work/_temp/fc79611f-9307-43bd-9b0e-2d2ab2621951' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/gitgalaxy/gitgalaxy/gitgalaxy
Removing SSH command configuration
[command]/usr/bin/git config --local --name-only --get-regexp core.sshCommand
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/usr/bin/git config --local --name-only --get-regexp http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http.https://github.com/.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/usr/bin/git config --local --name-only --get-regexp ^includeIf.gitdir:
[command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Cleaning up orphan processes

== shard 2 (1666363 LOC) (failure) -- real
https://github.com/squid-protocol/gitgalaxy/actions/runs/40406097105/job/121864223669
repro: python tests/tools/pr_gates.py --fast
failing tests: tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[gzdoom] tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[odamex]
errors:
E AssertionError:
tests/doom_rosetta/test_doom_rosetta.py:47: AssertionError
FAILED tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[odamex] - AssertionError:
FAILED tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[gzdoom] - AssertionError:
##[error]Process completed with exit code 1.
log tail:
summary.functions: 20698 -> 20699
summary.gg_functions: 18489 -> 18490
file src/common/scripting/dap/BreakpointManager.cpp: func_hash '58f9ac83a54243aa' -> 'ba18f6e9aeeeea06'
file src/common/textures/formats/pngtexture.cpp: functions 11 -> 12, func_hash 'b673dee923d32828' -> 'bbe805881e56cbbe'
(bless an intended change with tests/tools/doom_rosetta_check.py --update --yes)
assert not "gzdoom: 7 difference(s) from the golden\n summary.callgraph_engine_only: 17 -> 21\n summary.callgraph_misses: 120 -...ile src/common/textures/formats/pngtexture.cpp: functions 11 -> 12, func_hash 'b673dee923d32828' -> 'bbe8058
2 failed, 9 passed, 26 deselected in 201.19s (0:03:21)
##[error]Process completed with exit code 1.
##[group]Run s=$(( $(date +%s) - T0 ))
s=$(( $(date +%s) - T0 ))
echo "shard 2 (1666363 LOC): ${s}s" >> "$GITHUB_STEP_SUMMARY"
shell: /usr/bin/bash -e {0}
env:
GITGALAXY_LICENSE_KEY: COMMUNITY_FREE_TIER
DOOM_SPEEDRUN_WORK: /home/runner/work/gitgalaxy/gitgalaxy/../doom-work
DOOM_ROSETTA_PORTS: agentic-cobol-doom-codex,doom-ascii,doom-fx,doom-scheme,doom3do,doomretro,fps-cob,gzdoom,mochadoom,nugget-doom,odamex
T0: 1793050748
pythonLocation: /opt/hostedtoolcache/Python/3.12.15/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib
##[endgroup]
Post job cleanup.
[command]/usr/bin/git version
git version 2.55.0
Temporarily overriding HOME='/home/runner/work/_temp/84e733f0-ecde-4ebd-b7f0-8c2803b125de' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/gitgalaxy/gitgalaxy/gitgalaxy
Removing SSH command configuration
[command]/usr/bin/git config --local --name-only --get-regexp core.sshCommand
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/usr/bin/git config --local --name-only --get-regexp http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http.https://github.com/.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/usr/bin/git config --local --name-only --get-regexp ^includeIf.gitdir:
[command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Cleaning up orphan processes

== shard 3 (1667394 LOC) (failure) -- real
https://github.com/squid-protocol/gitgalaxy/actions/runs/40406097105/job/121864223698
repro: python tests/tools/pr_gates.py --fast
failing tests: tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[eternity]
errors:
E AssertionError:
tests/doom_rosetta/test_doom_rosetta.py:47: AssertionError
FAILED tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[eternity] - AssertionError:
##[error]Process completed with exit code 1.
log tail:
eternity: 3 difference(s) from the golden
summary.callgraph_misses: 22 -> 20
summary.callgraph_recall: 0.9986 -> 0.9987
file source/acs_intr.h: func_hash '501716b534089ac0' -> 'e633745d63c78bec'
(bless an intended change with tests/tools/doom_rosetta_check.py --update --yes)
assert not "eternity: 3 difference(s) from the golden\n summary.callgraph_misses: 22 -> 20\n summary.callgraph_recall: 0.9986 -> 0.9987\n file source/acs_intr.h: func_hash '501716b534089ac0' -> 'e633745d63c78bec'"
1 failed, 10 passed, 26 deselected in 204.00s (0:03:23)
##[error]Process completed with exit code 1.
##[group]Run s=$(( $(date +%s) - T0 ))
s=$(( $(date +%s) - T0 ))
echo "shard 3 (1667394 LOC): ${s}s" >> "$GITHUB_STEP_SUMMARY"
shell: /usr/bin/bash -e {0}
env:
GITGALAXY_LICENSE_KEY: COMMUNITY_FREE_TIER
DOOM_SPEEDRUN_WORK: /home/runner/work/gitgalaxy/gitgalaxy/../doom-work
DOOM_ROSETTA_PORTS: doom-ios,doom-wasm,doom3-bfg,dsda-doom,eternity,freedoom,fsharp-doom,gore,linuxdoom,puredoom,woof
T0: 1793050751
pythonLocation: /opt/hostedtoolcache/Python/3.12.15/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib
##[endgroup]
Post job cleanup.
[command]/usr/bin/git version
git version 2.55.0
Temporarily overriding HOME='/home/runner/work/_temp/a0ae87f4-1786-4e5d-8572-bd986bdbf841' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/gitgalaxy/gitgalaxy/gitgalaxy
Removing SSH command configuration
[command]/usr/bin/git config --local --name-only --get-regexp core.sshCommand
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/usr/bin/git config --local --name-only --get-regexp http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http.https://github.com/.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/usr/bin/git config --local --name-only --get-regexp ^includeIf.gitdir:
[command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Cleaning up orphan processes

1 similar comment
@squid-shepherd

Copy link
Copy Markdown
Contributor

PR #6754 @ e8bd45f: 3 failed check(s)

== shard 1 (1669449 LOC) (failure) -- real
https://github.com/squid-protocol/gitgalaxy/actions/runs/40406097105/job/121864223899
repro: python tests/tools/pr_gates.py --fast
failing tests: tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[doomsday] tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[edge-classic]
errors:
E AssertionError:
tests/doom_rosetta/test_doom_rosetta.py:47: AssertionError
FAILED tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[doomsday] - AssertionError:
FAILED tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[edge-classic] - AssertionError:
##[error]Process completed with exit code 1.
log tail:
FAILED tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[edge-classic] - AssertionError:
edge-classic: 2 difference(s) from the golden
file source_files/edge/r_image.cc: func_hash 'e559ee70ca2d0fe9' -> '75691cfb4bacc524'
file source_files/epi/epi_str_hash.h: func_hash 'e56a9d84bc3bca9d' -> '8eaa046569161062'
(bless an intended change with tests/tools/doom_rosetta_check.py --update --yes)
assert not "edge-classic: 2 difference(s) from the golden\n file source_files/edge/r_image.cc: func_hash 'e559ee70ca2d0fe9' -> '75691cfb4bacc524'\n file source_files/epi/epi_str_hash.h: func_hash 'e56a9d84bc3bca9d' -> '8eaa046569161062'"
2 failed, 8 passed, 26 deselected in 202.75s (0:03:22)
##[error]Process completed with exit code 1.
##[group]Run s=$(( $(date +%s) - T0 ))
s=$(( $(date +%s) - T0 ))
echo "shard 1 (1669449 LOC): ${s}s" >> "$GITHUB_STEP_SUMMARY"
shell: /usr/bin/bash -e {0}
env:
GITGALAXY_LICENSE_KEY: COMMUNITY_FREE_TIER
DOOM_SPEEDRUN_WORK: /home/runner/work/gitgalaxy/gitgalaxy/../doom-work
DOOM_ROSETTA_PORTS: chocolate-doom,cssdoom,dartdoom,doomgeneric,doomsday,edge-classic,mood,room4doom,rust-doom,sdl-doom
T0: 1793050755
pythonLocation: /opt/hostedtoolcache/Python/3.12.15/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib
##[endgroup]
Post job cleanup.
[command]/usr/bin/git version
git version 2.55.0
Temporarily overriding HOME='/home/runner/work/_temp/fc79611f-9307-43bd-9b0e-2d2ab2621951' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/gitgalaxy/gitgalaxy/gitgalaxy
Removing SSH command configuration
[command]/usr/bin/git config --local --name-only --get-regexp core.sshCommand
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/usr/bin/git config --local --name-only --get-regexp http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http.https://github.com/.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/usr/bin/git config --local --name-only --get-regexp ^includeIf.gitdir:
[command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Cleaning up orphan processes

== shard 2 (1666363 LOC) (failure) -- real
https://github.com/squid-protocol/gitgalaxy/actions/runs/40406097105/job/121864223669
repro: python tests/tools/pr_gates.py --fast
failing tests: tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[gzdoom] tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[odamex]
errors:
E AssertionError:
tests/doom_rosetta/test_doom_rosetta.py:47: AssertionError
FAILED tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[odamex] - AssertionError:
FAILED tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[gzdoom] - AssertionError:
##[error]Process completed with exit code 1.
log tail:
summary.functions: 20698 -> 20699
summary.gg_functions: 18489 -> 18490
file src/common/scripting/dap/BreakpointManager.cpp: func_hash '58f9ac83a54243aa' -> 'ba18f6e9aeeeea06'
file src/common/textures/formats/pngtexture.cpp: functions 11 -> 12, func_hash 'b673dee923d32828' -> 'bbe805881e56cbbe'
(bless an intended change with tests/tools/doom_rosetta_check.py --update --yes)
assert not "gzdoom: 7 difference(s) from the golden\n summary.callgraph_engine_only: 17 -> 21\n summary.callgraph_misses: 120 -...ile src/common/textures/formats/pngtexture.cpp: functions 11 -> 12, func_hash 'b673dee923d32828' -> 'bbe8058
2 failed, 9 passed, 26 deselected in 201.19s (0:03:21)
##[error]Process completed with exit code 1.
##[group]Run s=$(( $(date +%s) - T0 ))
s=$(( $(date +%s) - T0 ))
echo "shard 2 (1666363 LOC): ${s}s" >> "$GITHUB_STEP_SUMMARY"
shell: /usr/bin/bash -e {0}
env:
GITGALAXY_LICENSE_KEY: COMMUNITY_FREE_TIER
DOOM_SPEEDRUN_WORK: /home/runner/work/gitgalaxy/gitgalaxy/../doom-work
DOOM_ROSETTA_PORTS: agentic-cobol-doom-codex,doom-ascii,doom-fx,doom-scheme,doom3do,doomretro,fps-cob,gzdoom,mochadoom,nugget-doom,odamex
T0: 1793050748
pythonLocation: /opt/hostedtoolcache/Python/3.12.15/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib
##[endgroup]
Post job cleanup.
[command]/usr/bin/git version
git version 2.55.0
Temporarily overriding HOME='/home/runner/work/_temp/84e733f0-ecde-4ebd-b7f0-8c2803b125de' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/gitgalaxy/gitgalaxy/gitgalaxy
Removing SSH command configuration
[command]/usr/bin/git config --local --name-only --get-regexp core.sshCommand
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/usr/bin/git config --local --name-only --get-regexp http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http.https://github.com/.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/usr/bin/git config --local --name-only --get-regexp ^includeIf.gitdir:
[command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Cleaning up orphan processes

== shard 3 (1667394 LOC) (failure) -- real
https://github.com/squid-protocol/gitgalaxy/actions/runs/40406097105/job/121864223698
repro: python tests/tools/pr_gates.py --fast
failing tests: tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[eternity]
errors:
E AssertionError:
tests/doom_rosetta/test_doom_rosetta.py:47: AssertionError
FAILED tests/doom_rosetta/test_doom_rosetta.py::test_port_matches_golden[eternity] - AssertionError:
##[error]Process completed with exit code 1.
log tail:
eternity: 3 difference(s) from the golden
summary.callgraph_misses: 22 -> 20
summary.callgraph_recall: 0.9986 -> 0.9987
file source/acs_intr.h: func_hash '501716b534089ac0' -> 'e633745d63c78bec'
(bless an intended change with tests/tools/doom_rosetta_check.py --update --yes)
assert not "eternity: 3 difference(s) from the golden\n summary.callgraph_misses: 22 -> 20\n summary.callgraph_recall: 0.9986 -> 0.9987\n file source/acs_intr.h: func_hash '501716b534089ac0' -> 'e633745d63c78bec'"
1 failed, 10 passed, 26 deselected in 204.00s (0:03:23)
##[error]Process completed with exit code 1.
##[group]Run s=$(( $(date +%s) - T0 ))
s=$(( $(date +%s) - T0 ))
echo "shard 3 (1667394 LOC): ${s}s" >> "$GITHUB_STEP_SUMMARY"
shell: /usr/bin/bash -e {0}
env:
GITGALAXY_LICENSE_KEY: COMMUNITY_FREE_TIER
DOOM_SPEEDRUN_WORK: /home/runner/work/gitgalaxy/gitgalaxy/../doom-work
DOOM_ROSETTA_PORTS: doom-ios,doom-wasm,doom3-bfg,dsda-doom,eternity,freedoom,fsharp-doom,gore,linuxdoom,puredoom,woof
T0: 1793050751
pythonLocation: /opt/hostedtoolcache/Python/3.12.15/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib
##[endgroup]
Post job cleanup.
[command]/usr/bin/git version
git version 2.55.0
Temporarily overriding HOME='/home/runner/work/_temp/a0ae87f4-1786-4e5d-8572-bd986bdbf841' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/gitgalaxy/gitgalaxy/gitgalaxy
Removing SSH command configuration
[command]/usr/bin/git config --local --name-only --get-regexp core.sshCommand
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/usr/bin/git config --local --name-only --get-regexp http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http.https://github.com/.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/usr/bin/git config --local --name-only --get-regexp ^includeIf.gitdir:
[command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Cleaning up orphan processes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant