chore: replace interface{} with any in Go/SQLite code generation#4487
Open
MD-Mushfiqur123 wants to merge 1 commit into
Open
chore: replace interface{} with any in Go/SQLite code generation#4487MD-Mushfiqur123 wants to merge 1 commit into
MD-Mushfiqur123 wants to merge 1 commit into
Conversation
Replaces all auto-generated interface{} with any in Go/SQLite code
generation templates and type mapping functions. This is the modern Go
idiom since Go 1.18 (any is a built-in alias for interface{}).
Changes:
- sqlite_type.go: return 'any' instead of 'interface{}' for SQLite
'any' type and unknown type default case
- go_type.go: return 'any' instead of 'interface{}' for unknown engine
default case
- result.go: update type comparison from 'interface{}' to 'any'
- template.tmpl: Scan() methods use 'any' parameter type
- stdlib/queryCode.tmpl: use '[]any' instead of '[]interface{}'
- stdlib/dbCode.tmpl: DBTX interface and helpers use '...any'
- Update all SQLite endtoend test golden files
Signed-off-by: Md Mushfiqur Rahim <20mahin2020@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces all auto-generated
interface{}withanyin Go/SQLite code generation templates and type mapping functions. This is the modern Go idiom since Go 1.18 (anyis a built-in alias forinterface{}).Changes:
sqlite_type.go: returnanyinstead ofinterface{}for SQLiteanytype and unknown type default casego_type.go: returnanyinstead ofinterface{}for unknown engine default caseresult.go: update type comparison frominterface{}toanytemplate.tmpl: Scan() methods useanyparameter typestdlib/queryCode.tmpl: use[]anyinstead of[]interface{}stdlib/dbCode.tmpl: DBTX interface and helpers use...anyCloses #4470