Fix Aether stub downloader test isolation#2496
Open
hutiefang76 wants to merge 1 commit into
Open
Conversation
Fixes spring-cloudgh-2478 Signed-off-by: hutiefang <hutiefang@qq.com>
hutiefang76
force-pushed
the
codex/scc-2478-aether-test-isolation
branch
from
b8ecb4f to
321b9bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-2478
This re-enables
AetherStubDownloaderSpecby removing the class-level@Ignoreand making the remote-missing-artifact test self-contained.Before this change, the test asserted that
spring-cloud-contract-specwas already present in the developer's local Maven repository. That made the spec fail on a clean checkout unless a broadermvn installhad been run first.The test now uses the stub-runner module's existing
m2repotest fixture as the configured local repository, while keeping the remote repository empty. This preserves the original assertion that remote mode should not accidentally resolve from the configured local repository when the remote artifact is missing, without depending on machine-local Maven state.Verification:
Result:
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0andBUILD SUCCESS.