fix(docs): correct stale flush() docstrings and restore before_galileo examples (SAO-16166) - #232
Open
etserend wants to merge 1 commit into
Open
fix(docs): correct stale flush() docstrings and restore before_galileo examples (SAO-16166)#232etserend wants to merge 1 commit into
etserend wants to merge 1 commit into
Conversation
…o examples (SAO-16166) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #217 (HYBIM-966). PR #217 removed stale
flush()calls from examples but did not update the four public docstrings its description promised, and incorrectly removedlogger.flush()from the galileo "Before" migration snippets.singleton.py/decorator.py— four docstrings: replace "upload and clear" / "Upload all captured traces" with drain-only wordingsplunk-ao-migration-tool/examples/before_galileo.py— restorelogger.flush() # uploads traces(galileo's flush genuinely uploads; the line correctly shows what callers remove when migrating)splunk-ao-migration-tool/README.md— same restoration in the Before (galileo) block; After (splunk-ao) block is unchangedNo behavior changes. Docs and docstrings only.
Closes https://splunk.atlassian.net/browse/SAO-16166
🤖 Generated with Claude Code