Repository navigation
Conversation
…vity Cloud-managed executors for auto-indexing and server-side Batch Changes use the same Private Connectivity methods as private code hosts, so their jobs can pull from internal package and container registries. The Private Connectivity section now says so, and the Customer-managed executors section points out that Private Connectivity usually covers registry access without running your own executors. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-c2c49e6a-8194-4e78-9204-53c7b947eca6
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Contributor
|
Direct preview links to pages changed in this PR: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Private Connectivity section of /cloud never said that executors can use these connections. This PR adds two short changes to
docs/cloud/index.mdx:Platform confirmed this behavior in Slack: https://sourcegraph.slack.com/archives/C09T33U82JU/p1793926571017239
I didn't change the four
private-connectivity-*.mdxpages. The AWS, GCP, and alternate public load balancer pages already cover artifact registries, including executor secrets for registries that need authentication. The Sourcegraph Connect page already lists artifact registries and asks for the resource's ports.Test plan
pnpm run check links --check-anchors --check-self-linksagainst the merge-base baseline reports no new dead links.dev/check-hostnames.mjs,dev/check-duplicates.mjs, anddev/check-spelling.mjson the diff report no issues./cloudrenders on the dev server, and I checked both changed paragraphs in a browser.