fix: correct recorder revive after connecting different source - #1201
Open
mdydek wants to merge 4 commits into
Open
fix: correct recorder revive after connecting different source#1201mdydek wants to merge 4 commits into
mdydek wants to merge 4 commits into
Conversation
mdydek
changed the title
closetcaiman
requested changes
Aug 3, 2026
Comment on lines
+152
to
155
| if (fileResult.is_err()) { | ||
| if (shouldArmInput) { | ||
| [nativeRecorder_ setInputArmed:true]; | ||
| } |
WPT non-regression comparisonPASS — no regressions · 0 improved section(s) · overall 2589 → 2589 (0) Unchanged sections (28)
Baseline: Workflow run · this comment is updated on every push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1179
Introduced changes
Checklist