Repository navigation
nav-fund-services: Make sure the queried date range does not go past FundOfficialAccountingLastAvailableDate - #5392
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 76adcbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…FundOfficialAccountingLastAvailableDate
dskloetc
force-pushed
the
kloet/nav-fund-dates
branch
from
September 23, 2026 14:15
896e000 to
76adcbc
Compare
dskloetc
marked this pull request as ready for review
September 23, 2026 14:49
mohamed-mehany
approved these changes
Sep 24, 2026
Merged
4 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/OPDATA-8508
Description
When trying to get data for a new GlobalFundID, I was getting errors about the queried date range. It turned out there is an extra requirement that the
toDateis not allowed to be after the value ofFundOfficialAccountingLastAvailableDate.This was never an issue because apparently FundOfficialAccountingLastAvailableDate and toDate were aligned on other funds. But not with this new fund.
Changes
Steps to Test
Quality Assurance
infra-k8sconfiguration file.adapter-secretsconfiguration file.test-payload.jsonfile with relevant requests.feature/x,chore/x,release/x,hotfix/x,fix/x) or is created from Jira.