feat: check requests to install an app - #646
Draft
AmyScript wants to merge 1 commit into
Draft
Conversation
Add a hidden `slack app requests` command behind the app-approval-status experiment that reports the most recent install approval request for the selected app on each team in the token's scope. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
==========================================
+ Coverage 72.26% 72.38% +0.12%
==========================================
Files 238 239 +1
Lines 20072 20201 +129
==========================================
+ Hits 14505 14623 +118
- Misses 4298 4305 +7
- Partials 1269 1273 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Added the
app-approval-statusexperiment with aslack app requestscommand that checks the status of your most recent request to have an app approved for install.Summary
Installing an app on a team with admin approval required creates an approval request, but there was no way to check what happened to it from the CLI. This adds a hidden
slack app requestscommand, gated behind the newapp-approval-statusexperiment, that reports the most recent request for the selected app on each team in the token's scope.Requests are searched on the team of the authenticated account. An account of a workspace belonging to an organization also searches that organization, while an account of an organization searches the organization alone. Other workspaces of an organization can be searched with
--team-ids, up to the 50 the API accepts.Output includes the request ID, status, and timestamps, plus the actor that cancelled a request and a hint when the account can install the app without approval:
Preview
No recording yet — the command is unreleased and hidden, and the output above is taken from the unit tests rather than a live run.
Testing
--experiment app-approval-status, that--team-idsrejects more than 50 teams, and that the command requires a project directory.apps.approvals.requests.listhas not been exercised yet.Notes
Hidden, matching howmanifest syncgates itself; the experiment check lives inPreRunE.feature_not_enabledandrestricted_actionerror codes returned by the endpoint.Requirements
Made with Cursor