Skip to content

feat: support the code_channels manifest feature #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zimeg wants to merge 1 commit into
base: main
Choose a base branch
from
+33 −0
Draft

feat: support the code_channels manifest feature #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions internal/shared/types/app_manifest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ type AppFeatures struct {
ManifestSlashCommandsItems []ManifestSlashCommandsItem `json:"slash_commands,omitempty" yaml:"slash_commands,flow,omitempty"`
Search *Search `json:"search,omitempty" yaml:"search,flow,omitempty"`
RichPreviews *RichPreviews `json:"rich_previews,omitempty" yaml:"rich_previews,flow,omitempty"`
CodeChannels *CodeChannels `json:"code_channels,omitempty" yaml:"code_channels,flow,omitempty"`
}

type RichPreviews struct {
Expand Down Expand Up @@ -289,6 +290,15 @@ type Search struct {
EnableAIAnswers *bool `json:"enable_ai_answers,omitempty" yaml:"enable_ai_answers,omitempty"`
}

// CodeChannels contains settings for apps that create code channels: dedicated
// channels where an agent collaborates with a user on a task. Enabled is a
// pointer so an explicit `false` (feature turned off) is distinguishable from
// an unset field.
type CodeChannels struct {
Enabled *bool `json:"enabled,omitempty" yaml:"enabled,omitempty"`
SlashCommandURL string `json:"slash_command_url,omitempty" yaml:"slash_command_url,omitempty"`
}

// Workflow defines the structure of a workflow in the app manifest.
type Workflow struct {
Title string `json:"title" yaml:"title"`
Expand Down
23 changes: 23 additions & 0 deletions internal/shared/types/app_manifest_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,29 @@ func Test_AppManifest_AppFeatures(t *testing.T) {
},
want: `{"app_home":{},"bot_user":{"display_name":"business_bot"},"rich_previews":{"entity_types":["slack#/entities/file"]}}`,
},
"includes code channels when provided": {
features: AppFeatures{
BotUser: BotUser{
DisplayName: "coding_agent",
},
CodeChannels: &CodeChannels{
Enabled: new(true),
SlashCommandURL: "https://example.com/slack/code-channel-commands",
},
},
want: `{"app_home":{},"bot_user":{"display_name":"coding_agent"},"code_channels":{"enabled":true,"slash_command_url":"https://example.com/slack/code-channel-commands"}}`,
},
"serializes code channels disabled explicitly": {
features: AppFeatures{
BotUser: BotUser{
DisplayName: "coding_agent",
},
CodeChannels: &CodeChannels{
Enabled: new(false),
},
},
want: `{"app_home":{},"bot_user":{"display_name":"coding_agent"},"code_channels":{"enabled":false}}`,
},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
Expand Down
Loading