style: split expected-payload attributes in blocks tests - #231
Merged
Conversation
Expand the compact single-line dict/list literals in the expected payloads of test_plan, test_rich_text, test_table, and test_task_card onto one attribute per line with trailing commas, matching the multi-line style used elsewhere in the block-kit tests. Formatting-only: the parsed AST is identical to before, so every assertion behaves the same, and ruff accepts both forms (CI unaffected). Pulled out of the composition-objects examples PR, where this restyle was out of scope — those blocks tests landed earlier via #4, #35, and #100. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg
added
update
Member
Author
|
🧪 note: Testing changes so I will merge once tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the compact single-line dict/list literals in the
expectedpayloads oftest_plan,test_rich_text,test_table, andtest_task_cardonto one attribute per line with trailing commas — matching the multi-line style used elsewhere in theblock-kittests.Formatting-only. The parsed AST of each file is byte-for-byte identical to
main(verified withast.dump), so every assertion behaves exactly the same, andruff format --checkaccepts both the compact and the split form — CI is unaffected either way.Why a separate PR
This restyle was originally riding along in the composition-objects examples branch (#228), where it was out of scope — those four blocks tests landed earlier via #4, #35, and #100. Pulling it out here keeps #228 scoped to
compositions/+ the README, and lets this stylistic choice be reviewed on its own.🤖 Generated with Claude Code