Fix AsyncStream release JNI binding - #51
Merged
marcprux merged 2 commits intoSep 23, 2026
Merged
Conversation
|
Thank you for your pull request and welcome to the Skip community. We require contributors to sign our contributor license agreement (CLA), and we don't seem to have the user(s) @michele-theleftbit on file. In order for us to review and merge your code, for each noted user please add your GitHub username to Skip's .clabot file |
|
Thank you for your pull request and welcome to the Skip community. We require contributors to sign our contributor license agreement (CLA), and we don't seem to have the user(s) @6kko on file. In order for us to review and merge your code, for each noted user please add your GitHub username to Skip's .clabot file |
michele-theleftbit
force-pushed
the
fix/asyncstream-release-jni
branch
from
September 23, 2026 12:31
856e409 to
3000e62
Compare
Member
|
Perfect, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50.
Adds stable
@JvmName("Swift_release")directives for bothAsyncStreamSwiftDataSourceandAsyncThrowingStreamSwiftDataSource, matchingSwift_nextand preventing Kotlin from looking up the mangledSwift_release$SkipLibJNI symbol.Validation:
swift testwas not run locally.AI was used to help investigate the generated binding and prepare this focused change; I manually reviewed the final diff.