Skip to content

Fix AsyncStream release JNI binding - #51

Merged
marcprux merged 2 commits into
skiptools:mainfrom
michele-theleftbit:fix/asyncstream-release-jni
Sep 23, 2026
Merged

marcprux merged 2 commits into
skiptools:mainfrom
michele-theleftbit:fix/asyncstream-release-jni

Conversation

@michele-theleftbit

Copy link
Copy Markdown
Contributor

Fixes #50.

Adds stable @JvmName("Swift_release") directives for both AsyncStreamSwiftDataSource and AsyncThrowingStreamSwiftDataSource, matching Swift_next and preventing Kotlin from looking up the mangled Swift_release$SkipLib JNI symbol.

Validation:

  • Reviewed the generated Android binding and the two-line source diff.
  • swift test was not run locally.

AI was used to help investigate the generated binding and prepare this focused change; I manually reviewed the final diff.

@cla-bot

cla-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to the Skip community. We require contributors to sign our contributor license agreement (CLA), and we don't seem to have the user(s) @michele-theleftbit on file. In order for us to review and merge your code, for each noted user please add your GitHub username to Skip's .clabot file

@cla-bot

cla-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to the Skip community. We require contributors to sign our contributor license agreement (CLA), and we don't seem to have the user(s) @6kko on file. In order for us to review and merge your code, for each noted user please add your GitHub username to Skip's .clabot file

@michele-theleftbit
michele-theleftbit force-pushed the fix/asyncstream-release-jni branch from 856e409 to 3000e62 Compare September 23, 2026 12:31
@cla-bot cla-bot Bot added the cla-signed label Sep 23, 2026
@marcprux

Copy link
Copy Markdown
Member

Perfect, thanks!

@marcprux
marcprux merged commit 6378041 into skiptools:main Sep 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AsyncStream JNI release binding is mangled on Android

2 participants