Skip to content

Limit zip file entries to 100MB - #1037

Merged
Enkidu93 merged 1 commit into
mainfrom
zip_bounds
Aug 28, 2026
Merged

Limit zip file entries to 100MB#1037
Enkidu93 merged 1 commit into
mainfrom
zip_bounds

Conversation

@pmachapman

@pmachapman pmachapman commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Fixes #974.

Requires corresponding change in SIL.Machine.


This change is Reviewable

@pmachapman
pmachapman requested review from Enkidu93 and ddaspit August 20, 2026 01:28
@codecov-commenter

codecov-commenter commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.73%. Comparing base (ae68c83) to head (3afed28).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1037   +/-   ##
=======================================
  Coverage   72.73%   72.73%           
=======================================
  Files         392      392           
  Lines       21723    21723           
  Branches     2820     2820           
=======================================
  Hits        15801    15801           
  Misses       4799     4799           
  Partials     1123     1123           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Enkidu93

Copy link
Copy Markdown
Collaborator

If you merge your PR in Machine, I'm happy to slip that change into the Machine release so we can get this in as well.

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

@Enkidu93
Enkidu93 force-pushed the zip_bounds branch 2 times, most recently from a749678 to f2a98bd Compare August 28, 2026 21:18
@Enkidu93
Enkidu93 merged commit e9d932a into main Aug 28, 2026
1 of 2 checks passed
@Enkidu93
Enkidu93 deleted the zip_bounds branch August 28, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decompression-bomb risk parsing Paratext zips

3 participants