Skip to content

Simplify ExportWordReversal - #1115

Open
papeh wants to merge 1 commit into
mainfrom
bugfix/LT-22641-user-settings-crash
Open

Simplify ExportWordReversal#1115
papeh wants to merge 1 commit into
mainfrom
bugfix/LT-22641-user-settings-crash

Conversation

@papeh

@papeh papeh commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

CI-ready checklist

  • Commit messages follow .github/commit-guidelines.md.
  • As much as possible, the change is unit tested. Writing a test would require enough setup to actually export a Word document; this is done only in manual tests.
  • Builds pass.
  • I have considered all comments from an AI code reviewer (such as Devin)

Notes for reviewers (optional)


This change is Reviewable

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   12m 1s ⏱️ + 3m 57s
5 996 tests ±0  5 915 ✅ +1  81 💤 ±0  0 ❌  - 1 
6 005 runs  ±0  5 924 ✅ +1  81 💤 ±0  0 ❌  - 1 

Results for commit 966a285. ± Comparison against base commit 8f46a80.

♻️ This comment has been updated with latest results.

@codecov-commenter

codecov-commenter commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 38.55%. Comparing base (8f46a80) to head (966a285).

Files with missing lines Patch % Lines
Src/xWorks/DictionaryExportService.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1115      +/-   ##
==========================================
- Coverage   38.55%   38.55%   -0.01%     
==========================================
  Files        1513     1513              
  Lines      350968   350966       -2     
  Branches    40345    40345              
==========================================
- Hits       135322   135307      -15     
- Misses     186429   186443      +14     
+ Partials    29217    29216       -1     
Files with missing lines Coverage Δ
Src/xWorks/DictionaryExportService.cs 50.00% <0.00%> (+0.49%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@papeh
papeh force-pushed the bugfix/LT-22641-user-settings-crash branch from 032ec65 to 966a285 Compare September 2, 2026 16:32
@papeh papeh changed the title WIP: Simplify and test ExportWordReversal Simplify ExportWordReversal Sep 2, 2026
@papeh
papeh marked this pull request as ready for review September 2, 2026 16:51

@thejambi thejambi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@thejambi reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on papeh).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants