Skip to content

docs(runs): correct the spot interruptions comment in TaskView [COMP-1658] - #740

Merged
cristianrcv merged 1 commit into
masterfrom
fix/COMP-1658-task-view-comment
Nov 6, 2026
Merged

cristianrcv merged 1 commit into
masterfrom
fix/COMP-1658-task-view-comment

Conversation

@jonmarti

@jonmarti jonmarti commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Comment only, no behaviour change. Jira: COMP-1658.

🤖 Generated with Claude Code

AWS Batch and Google Batch count real spot interruptions, so they do
not report 0 on every task as the comment claimed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jonmarti
jonmarti requested review from a team and a balanced review from Copilot November 6, 2026 18:01

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve: a one-line comment fix with no change in behaviour.

The diff only rewords the comment above the numSpotInterruptions check in TaskView.toString. The old comment said AWS and Google Batch report 0 on every task, which contradicts the code right below it: the row appears only when the value is greater than 0. The new wording ("Most tasks report 0") matches what the code does. The code itself is unchanged.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the comment-only clarification of why zero-count spot-interruption rows are hidden.

No open issues 🎉

What changed in this PR

Corrects the comment above the Spot interruptions row in TaskView, removing the inaccurate claim that AWS Batch and Google Batch always report zero interruptions.

Changes:

  • Clarifies why zero-count rows are hidden; runtime behavior remains unchanged.
File Description
src/​main/​java/​io/​seqera/​tower/​cli/​responses/​runs/​tasks/​TaskView.java Corrects the spot-interruption comment without changing display logic.

Review effort: Balanced

@cristianrcv
cristianrcv merged commit 3d56229 into master Nov 6, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants