test: Cover PUT and DELETE retries through generated routes - #584
Open
razor-x wants to merge 1 commit into
Open
Conversation
The retry specs exercised only GET, plus a POST negative through the raw client, so nothing asserted the documented policy for the verbs the retry layer actually repeats. Count attempts through generated PUT, DELETE, PATCH, and POST routes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQW83gyXeUG61RDrHEky97
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SDK audit test-suite finding: the retry specs exercised GET only (plus a POST negative through the raw client), so no spec covered the verbs the retry layer actually repeats, and no generated PUT or DELETE route was exercised anywhere in the suite.
Change
Test-only.
spec/seam_client/retry_spec.rbcounts attempts through generated routes:access_codes.create_multiple(PUT) andaccess_codes.delete(DELETE) are retried after a 503,access_codes.update(PATCH) andlocks.unlock_door(POST) are not. This pins the policy the README documents; the PUT retry itself was reviewed and kept in the earlier waves (PUT routes are idempotent server-side).🤖 Generated with Claude Code
https://claude.ai/code/session_01SQW83gyXeUG61RDrHEky97
Generated by Claude Code