Repository navigation
Re-enable the full Windows test matrix and fix platform failures - #911
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows CI has been disabled since #836. Restore the full test matrix on Windows for every supported Ruby (2.6–4.0), alongside Linux, and remove the Windows and AppVeyor exclusions from the specs. Give the slower Windows jobs 30 minutes to complete the integration suite while retaining the 15-minute Linux limit. Both platforms now run the same 1,679 examples; no examples are removed or newly skipped.
The restored matrix exposed two production failures:
File.open(...).readleaves handles open until garbage collection, preventing Windows from deletingMERGE_MODE. UseFile.readso the handles close immediately. Also close readers and temporary files in the Gerrit specs, and retain commit-message fixtures until each example finishes, to prevent Windows finalizer errors.Win32_Processthrough PowerShell'sGet-CimInstance, preserving thenilfallback when the command cannot launch or the parent has exited.Use Ruby's native symlink APIs on Windows instead of invoking
mklinkand parsingdiroutput. This supports directory links, raises on creation failures, and lets the restored specs exercise real symlinks withcore.symlinks=true. Ten additional examples cover files, directories, missing targets, spaces, and creation errors.Repair the parallelism regression spec: its previous built-in hook ignored the configured sleep command. An ad hoc serial hook now actually sleeps and writes a marker; the spec requires a successful commit and verifies the marker. Allow 30 seconds for Git and interpreter startup on slower Windows runners instead of the flaky five-second deadline. Two additional examples cover unavailable Windows process information.
Validation:
03e86dc5.Refs #836 and #910.