fix: leaf circuit (tower module) - #1372
Closed
kunxian-xia wants to merge 7 commits into
Closed
Conversation
3 tasks
## Summary - wire fork/global transcript ownership for tower and main transcript events - derive the main transcript claim from the tower replay instead of a placeholder - gate placeholder batch transcript samples so single-shard recursion v2 e2e balances buses ## contents - [x] TowerLayerSumcheckAir - [ ] TowerInputAir - [ ] TowerLayerAir ## Tests - PASS: RUST_MIN_STACK=33554432 CENO_RECURSION_V2_TEST_LOG=logs/e2e-final-fix-tower-e2e-transcript-bus.log scripts/run_e2e_test.sh - FAIL: RUST_MIN_STACK=33554432 cargo test 'continuation::tests::prover_integration::agg_prover_two_shards' -- --nocapture - fails in VmPvsAir row constraints; log saved at logs/e2e-two-shards.log Stacked on #1372 (base branch: fix/recursion-v2).
## Summary - enable only Transcript, ProofShape, and Tower in the recursion v2 system subcircuit - skip Main and BatchConstraint preflight/trace/AIR wiring for the reduced circuit - leave TODOs on disabled outbound bus edges while preserving VmPvs transcript/public-values consumers ## Verification - cargo fmt --all - cargo check --workspace --all-targets - cargo make clippy - CENO_RECURSION_V2_DEBUG_CONSTRAINTS=1 scripts/run_e2e_test.sh - scripts/run_e2e_test.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.