Repository navigation
Cache the Pint result in the Laravel static checks - #14
Merged
Merged
Conversation
Pint checked every file on each run, about 25-40 s on a GitHub runner. The automatic Pint step now writes its cache to the runner's temporary folder, and the analysis cache step saves and restores it. Pint stores its version and rules in the cache, so an outdated cache is discarded. The guide explains how a custom lint-command can use the same cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Static checksjob oflaravel-ci.ymlran Pint on every file on each run. On a GitHub runner this takes about 25-40 s for a project with 600 PHP files.Changes:
pint --test --cache-file=$RUNNER_TEMP/pint.cache.Cache PHPStan, Rector and Pint results.lint-commandcan use the cache:cache-fileinpint.json, plus the file inanalysis-cache-paths.Pint (PHP-CS-Fixer) stores its version, the PHP version and the rules in the cache. It discards a cache that does not match, so a Pint upgrade or a
pint.jsonchange cannot give a false pass.No new inputs. Existing callers need no change.