[williamloo-scale]

The gateway side of website/v1: the address a site is reached at, and triggers matched by route. Keyed roles were part of this change and are held back for a design with one key per role (see below).

• Forwarded headers. /svc and /website set X-Forwarded-Host, -Proto and -Prefix and drop the client's copies; a front's own X-Forwarded-Host and -Proto win, else the request's Host and scheme. The SDK takes the prefix as the root path, so base_url, request.url and redirects name the gateway's address. Behind the prefix, a site still judges its reserved paths and the clock rule by its own path: a catch-all @api route can't answer /agentenv/..., and with the clock unreadable the card, the data plane and sync_time still answer at /svc/<name>/.
• Triggers by route. A website trigger's when may name op, a route of the site's card, and then matches only requests that reach it. Registration refuses an op the card doesn't name, and an op on a site whose card can't be read. triggers/v1 declares website_op, so an older gateway is refused. The card's website/v1 routes[].path is now the path the route is served at, converters included (/api/files/{rest:path}), so the gateway matches nested and typed paths.

Held back: keyed roles

One key per deploy let any holder, a deployed agent included, claim any role, and neither the hub nor agentenvhub-sdk sends the key yet. They return as one key per role, with the hub sending it. Here, as on main, the gateway believes the role header alone, and an SDK site, holding no key, treats every caller as default. The earlier commits of this branch keep the first version.

Test

• CI on this head. The protocol suite passed locally (1,207) and lint is clean.
• End to end on a VM, a local Docker gateway in front of an MCP server and two SDK sites. The run came before keyed roles were held back; the code below is unchanged since.
  • Forwarded headers: the site saw the gateway's host and prefix on /website and /svc. A client's X-Forwarded-Prefix and an invalid -Proto were ignored, and a trailing-slash redirect named the gateway's address. Conformance passed 8 of 8 through /svc.
  • Triggers by route: registration refuses an unknown op, listing the routes, and a non-website app. Op triggers matched GET, POST, HEAD and a nested {rest:path} route. An op trigger on a site whose card was down at registration was refused, then accepted once the site was back.
  • Lost clock: with the clock unreachable, pages behind /svc answered 503 while the card, data/get, ready and sync_time answered, and an unknown reserved path answered 404, not the catch-all.

🤖 Generated with Claude Code

Confidence Score: 5/5

The reviewed changes appear safe to merge.

Summary

This PR forwards the gateway address to websites and adds triggers that match named website routes.

• Proxied sites now see the gateway address and path.
• Website triggers can fire for a named route.

Diagram

sequenceDiagram
    participant Client
    participant Gateway
    participant Website
    participant Triggers
    Client->>Gateway: Request under /website or /svc
    Gateway->>Website: Forward request with gateway address headers
    Website-->>Gateway: Response
    Gateway->>Gateway: Match forwarded path to named route
    Gateway->>Triggers: Evaluate request with route name
    Triggers-->>Gateway: Wait for matching barrier, if any
    Gateway-->>Client: Return response

Loading

_{Reviews (18) · Last reviewed commit: "refactor(gateway)!: hold keyed roles bac..." · Reviewed by Greptile}

[earakely-scale]

A heads-up from #478 (M8.54). The driver's /svc/<app>/ now follows this PR's forwarded-header convention: it drops the caller's X-Forwarded-Host, -Proto and -Prefix and sets its own, and drops hop-by-hop headers and those a Connection header names. That lives in agentenv_protocol.computer.svc (passed_on, to_app), while this PR has its own in env/gateway/rest_proxy.py (HOP_BY_HOP, FORWARDED_*).

Once both merge, could the gateway use the same helpers, so there's one convention to keep in step (which headers drop, how X-Forwarded-Proto is set, a chained proxy's values)? No change needed in this PR; I'm happy to do it as a follow-up.

[greptile-apps]

Comments Outside Diff

These findings could not be posted inline.

•  Failed checks leave data erased packages/agentenv-protocol/src/agentenv_protocol/website/conformance.py:191 ▶

  _data_plane calls data/reset before entering the try and sets added_back = True before data/add succeeds. If reset clears data but returns an error, or the first add fails before restoring anything, cleanup never retries the saved export. The check reports failure but leaves the site's data missing.

  Put reset inside the protected block and mark the export restored only after add succeeds. Add tests for both failure paths; the existing test covers only a failed read after reset.